pkg/monitoredresource.Autodetect(): causes me to vendor aws-sdk-go

[census-ecosystem]

pkg/monitoredresource.Autodetect(): causes me to vendor aws-sdk-go

[rakyll]

We are considering to implement census-instrumentation/opencensus-specs#162 to detect monitored resources and thinking about splitting resource detection into a different package.

The auto-detection will be at the new resource package.

import "contrib.go.opencensus.io/resource"

resource.Autodetect()

And GCP and AWS will have split packages for detection.

[ahmetb]

I think the problem is Autodetect(). Anyone who needs to use Autodetect() will need to vendor both aws and gcp.

Otherwise I'd say:

• move type GCEInstance to a new package: monitoredresource/gcp (ditto for aws)
• keep interface monitoredresource.Interface where it is
• user now imports pkgs monitoredresource/gcp and monitoredresource both.
  • ^ I don't think this will work when people use Autodetect().

Right now the list of aws pkgs that go into my binary (without using aws) are:

github.com/aws/aws-sdk-go/internal/sdkrand
github.com/aws/aws-sdk-go/internal/sdkuri
github.com/aws/aws-sdk-go/aws/awserr
github.com/aws/aws-sdk-go/internal/shareddefaults
github.com/aws/aws-sdk-go/aws/endpoints
github.com/aws/aws-sdk-go/aws/credentials
github.com/aws/aws-sdk-go/aws/awsutil
github.com/aws/aws-sdk-go/aws
github.com/aws/aws-sdk-go/aws/request
github.com/aws/aws-sdk-go/aws/client
github.com/aws/aws-sdk-go/aws/corehandlers
github.com/aws/aws-sdk-go/private/protocol
github.com/aws/aws-sdk-go/private/protocol/rest
github.com/aws/aws-sdk-go/private/protocol/query/queryutil
github.com/aws/aws-sdk-go/aws/ec2metadata
github.com/aws/aws-sdk-go/private/protocol/xml/xmlutil
github.com/aws/aws-sdk-go/aws/signer/v4
github.com/aws/aws-sdk-go/aws/csm
github.com/aws/aws-sdk-go/private/protocol/query
github.com/aws/aws-sdk-go/aws/credentials/ec2rolecreds
github.com/aws/aws-sdk-go/service/sts
github.com/aws/aws-sdk-go/aws/credentials/stscreds
github.com/aws/aws-sdk-go/aws/credentials/endpointcreds
github.com/aws/aws-sdk-go/aws/defaults
github.com/aws/aws-sdk-go/aws/session

[semistrict]

I think we should split packages as follow:

• separate packages for each cloud provider
• separate package for autodetect that imports all of the above

Then if you know which cloud provider you want to support, you only import the package you need and you can avoid importing the autodetect package (which will pull in all providers).

[semistrict]

/cc @rghetia

[rghetia]

once census-instrumentation/opencensus-go#878 is committed we can deprecate autodetect. ChainDetector() can replace autodetect.

[songy23]

Duplicated of #144.