Comments (7)
I can go either way on this.
On one hand I expect anyone who uses this in production to have turned logs down to ERROR so we are not "production ready" by default there.
On other hand it's nice for new users just playing to start up in foreground with default config and get feedback about what's going on for each request.
In either case turning log level up or down is not so horrible.
That said your suggestion of minutely summaries sounds cool but it's a bunch of work and some overhead and I'm not sure how useful it would be in production in practice given that user should already have metrics setup telling them that graphically in better resolution etc.
I think I sway towards leave it like it is and just document somewhere that we expect production deployments to tune it down...
from centrifugo.
Also thought about the same things...There are some caveats with other INFO messages, like logging when SIGHUP received for example - it would be nice to see such messages in production when error
level set. This whole levelled logging concept looks broken a bit:(
from centrifugo.
In that case maybe make spammy stuff DEBUG.
Could even make that be the default if we like it being loud for first run users with default conf with recommendation in docks to turn it down
On 28 Jul 2016, at 15:40, Alexandr Emelin [email protected] wrote:
Also thought about the same things...There are some caveats with other INFO messages, like logging when SIGHUP received for example - it would be nice to see such messages when error level set. This whole levelled logging concept looks broken a bit:(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from centrifugo.
I was wrong about such a big performance impact.. Because I used logging into terminal STDOUT when measuring first time. Just tried logging into file and running wrk (on my old macbook air 2011): 17.5k requests/sec (info) vs 19.5 requests/sec (error level). So just too chatty problem should be considered here.
Btw for someone interested in measuring on its own computer:
centrifugo --insecure_api --log_level=error --log_file=/tmp/centrifugo.log
wrk:
wrk -t10 -c10 -d10s -s post.lua --latency http://localhost:8000/api/
post.lua:
wrk.method = "POST"
wrk.body = '{"method": "publish", "params": {"channel": "channel1", "data": "hello"}}'
wrk.headers["Content-Type"] = "application/json"
from centrifugo.
Another solution - leave API requests and connections as INFO but make logs like reloading configuration on SIGHUP as critical so it will be visible even on error
level. If anyone has problems with this I can add new log level (something like system
) for important messages from Centrifugo.
from centrifugo.
Calling stuff that is not an "error" condition "error" or even "warning" seems kinda hacky to me...
DEBUG for verbose per-request logging seems more sane...
from centrifugo.
@banks just made pull request with this
from centrifugo.
Related Issues (20)
- [feature] Precalculated presence stats counters in store HOT 8
- [feature] Add support for Ed25519 signature JWS HOT 2
- [bug] Channel Regex for Namespace cuased Null Pointer Exception HOT 2
- [feature] Add AMQP (RabbitMQ) support in async consumers API HOT 7
- [feature removal] Remove SockJS transport
- [feature] Improve health check by checking redis connection HOT 6
- [bug] The ID specified in XADD is equal or smaller than the target stream top item HOT 5
- [bug] getting "already subscribed" on page refresh HOT 3
- [feature] Silently Reject Publish Attempts on Proxied Channel Without Sending Client Errors HOT 4
- [question] What are the ways of decreasing the message payload? HOT 1
- [feature] Better error message when subscription token is used as connection token
- Unable To Connect With anonymous mode HOT 4
- [feature] serve admin interface via http2 HOT 4
- [feature] Send server time in initial connect response. HOT 2
- [question] Upgrading to 4.1.5 increase in response time HOT 3
- "Websocket Is Closed Before The Connection Is Established" - Web console error HOT 8
- [feature] Support for MessagePack Serialization HOT 2
- How to add multyple aud for a token in config file HOT 1
- [question] History StreamPosition and circular offsets. HOT 7
- [question] Centrifugo customization HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from centrifugo.