Should id values be formatted as strings by default?

[cerebris]

Should id values be formatted as strings by default?

[lgebhardt]

Yes, at this point we should be calling to_s on ids in order to be compliant with JSON API.

I think the spec should be changed to allow integer ids, since JSON supports integers. However until this is changed you are correct that jsonapi-resources is not compliant. I'll see about getting this fixed soon.

[barelyknown]

I plan on using this library for a number of projects, so I'd be happy to make that change if you'd like. Should we add the feature through a configuration flag, and if so, should we make the current behavior the default, or the compliant behavior the default?

[lgebhardt]

@barelyknown if you want to fix this that would be great. I think we should just go for compliance, so no configuration option is needed. If the spec changes we'll just go with that.

[barelyknown]

Sounds good. PR on its way later today.

[barelyknown]

Thanks for merging!