Comments (4)
Thanks for reporting this @trc-ikeskin!
I don't see any reason not to do this and it should be a relatively straightforward fix.
I will raise a tentative PR to address this issue in the coming days.
from istio-csr.
I think the reason this was not initially supported is that on the release of Istio 1.6 where ECC was introduced, only P256 was supported, but I can see now that P384 + P256 are both supported
This was introduced about 10 months ago in this PR
We will enable this key size option for both the Istiod cert and istio-csr's own server cert (which is the one your error comes from).
You'd still need to set the Istio installation configuration as show in the documentation here if you want all workload identities to use the same algorithm as we cannot override the incoming CSRs.
from istio-csr.
@SpectralHiss you are absolutely right. Shortly after opening this issue I found the PR myself.
Thank you for the heads up and your work on this!
from istio-csr.
@trc-ikeskin try this now and see if it works, you can find an example helm chart + istio install here
from istio-csr.
Related Issues (20)
- Add ability to annotate certificate requests generateed by istio-csr HOT 1
- Add custom annotations to deployment HOT 3
- charts.jetstack.io beding cluster presents a challenge and breaks deployment
- istio-csr vault integration - permission denied - Vault failed to sign certificate HOT 2
- Restarting a namespace with 30+ deployments causes errors in istio-csr which tends to reolve after a while. HOT 2
- Custom DNS support in istio-csr's istiod certificate HOT 1
- False positive warnings from trivy and dependabot HOT 2
- ClusterRole & ClusterRoleBindings for istio-csr
- TODO: tests - carotation creates two kind clusters
- Populate Subject Fields in Certificate HOT 1
- It is not possible to provide SAN for istiod certificate HOT 2
- how to build oci image locally using make command HOT 1
- Istio sidecar can only request new cert using istio-token HOT 1
- Document / improve that sometimes the issuer needs to set `ca.crt`
- Image version is v0.0.0 HOT 4
- Getting Readiness probe failed when using cert-manager-istio-csr HOT 1
- Modify schema validation for additional property domain HOT 3
- Document Link Fixes HOT 1
- Add support for Istio with Ambient mode HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from istio-csr.