Issue with 'ENCRYPT' in 'mongoose.h'

[gvanem]

Issue with 'ENCRYPT' in 'mongoose.h'

[cpq]

@scaprile prepending MG_ is the way to go, we should not be polluting user's namespace
Will you take care of it please?

[cpq]

I think the best way to deal with the realpath() type of issues, as well as all the other issues that arise from using things like mimalloc and similar tools, is to avoid using arch_win32.h - basically, our headers.

@gvanem So the realpath issue is different from the ENCRYPT macro, and should be fixed this way:

1. Set -DMG_ARCH=DMG_ARCH_CUSTOM
2. Make your own "mongoose_custom.h" and include there whatever deemed necessary - mimalloc, whatever.

@scaprile so please do just the ENCRYPT fix and don't touch realpath

[scaprile]

@cpq This is in the PD tls_aes128.[ch] files.
How should we proceed, do we prepend MG_ in both files or just #undef at the head of .h ?

[gvanem]

Here is another case; but only a redefinition warning. For this program:

#include <string.h>
#include <malloc.h>
#include <mimalloc/mimalloc-override.h> // From https://github.com/microsoft/mimalloc
#include <mongoose.h>
int main (void)
{
  return (0);
}

I get:

In file included from mongoose-ntddndis-error.c:6:
./externals\mongoose.h(499,9): warning: 'realpath' macro redefined [-Wmacro-redefined]
  499 | #define realpath(a, b) _fullpath((b), (a), MG_PATH_MAX)
      |         ^
./externals\mimalloc/mimalloc-override.h(28,9): note: previous definition is here
   28 | #define realpath(f,n)           mi_realpath(f,n)
      |         ^
1 warning generated.

Since _fullpath() allocates memory internally, mimalloc has this override function mi_realpath() for it.

[cpq]

Thank you @gvanem !

[scaprile]

@cpq How should we proceed with this last one ? Redefinition will depend on the order of inclusion, if we undef then the other one will warn. There is no undef in mimalloc-override https://github.com/microsoft/mimalloc/blob/master/include/mimalloc-override.h . Checking for mi_realpath and using theirs may not be a good choice.