Giter Site home page Giter Site logo

Comments (2)

javagl avatar javagl commented on June 2, 2024

For the specific case here, one veeeery deep root problem is what I found after adding some ridiculous debug logging of the vertex coordinates of each triangle of a unit square that was supposed to be tested for intersections:
Got (0, 0, 1) (0, 0, 1) (1, 0, 0) for 1 3 2

Wait, what?
Yeah.
The part at

verticesBuffer.getBufferData(
does not work for interleaved buffers.

When storing that unit square with non-interleaved buffers, it works.

I'll try to fix that, but will probably not be able to resist the urge do to a few other cleanups there as well. But I'll have to further wrap my head about some interdepdencies there - what's the role of the WebGL2 frame state and these typed arrays, or how attempting to fix the issue about interleaved buffers may be affected by the quantization. Eventually, it may include

  • a fix for this issue
  • a fix for #11814
  • avoiding a few million calls to defaultValue
  • avoiding that the dequantization and applying the exaggeration are both done six times for each vertex (they are done on the fly in getVertexPosition...)
  • having fewer than 300 lines in one function...

from cesium.

jjhembd avatar jjhembd commented on June 2, 2024

@javagl thanks for the test cases! Here's what I get from your sphere & airplane case after #11842

image

from cesium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.