Edit-config for union sr_val_t type not filled

[cesnet]

Edit-config for union sr_val_t type not filled

[rkrejci]

In devel branch the error is different:

[ERR] (sr_check_value_conform_to_schema:807) Value doesn't conform to schema expected 0 instead of 19                                                                                                                     
[ERR] (sr_val_to_str:1070) Value doesn't conform to schema node testunion                                                                                                                                                 
[ERR] (rp_dt_set_item:373) Copy new value to string failed
[ERR] (rp_dt_set_item_wrapper:574) Set item failed
[ERR] (rp_set_item_req_process:919) Set item failed for '/test:testunion', session id=921487922.

with the following model:

module test {
  namespace "test";
  prefix t;

  typedef u {
    type union {
      type string {
        pattern "disabled";
      }
      type uint8 {
        range "1..100";
      }
    }
    default "disabled";
  }
  leaf testunion {
    type u;
  }
}

and edit-config:

<rpc xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="2">
  <edit-config>
    <target>
      <candidate/>
    </target>
    <config>
      <testunion xmlns="test">10</testunion>
    </config>
  </edit-config>
</rpc>

It is unclear to me what kind of data are expected to be stored in sr_val_t in case of union. Netopeer actually know the type (SR_UINT8_T in this case) so the type detection in sysrepo could be skipped. Just storing the value as uint8_t and declaring type SR_UNION_T does not work:

netopeer2-server[21115]: (sr_set_val_t_type_in_gpb:1105) Type can not be mapped to gpb type '(null)' type 6
netopeer2-server[21115]: (sr_dup_val_t_to_gpb:1249) Setting type in gpb failed for xpath '(null)'
netopeer2-server[21115]: (sr_set_item:1695) value duplication failed.

[lukasmacko]

The value should be declared as actual type SR_UINT8_T in this case

[rkrejci]

That's how it is done currently in devel branch, but the result is following.
netopeer2-server log:

netopeer2-server[27919]: Resolving unresolved data nodes and their constraints...
netopeer2-server[27919]: All data nodes and constraints resolved.
netopeer2-server[27919]: (cl_request_process:483) Error by processing of the set-item request (session id=547989496): Invalid argument.
netopeer2-server[27919]: (sr_set_item:1699) Error by processing of the request.

sysrepod log:

[ERR] (sr_check_value_conform_to_schema:803) Value doesn't conform to schema expected 0 instead of 18
[ERR] (sr_val_to_str:1066) Value doesn't conform to schema node testunion
[ERR] (rp_dt_set_item:373) Copy new value to string failed
[ERR] (rp_dt_set_item_wrapper:574) Set item failed
[ERR] (rp_set_item_req_process:919) Set item failed for '/test:testunion', session id=547989496.

[lukasmacko]

OK, the issue was in sysrepo's typedef hadling. Should be fixed now

[joanlandry]

is the fix on the master branch?

[lukasmacko]

yes it is

[joanlandry]

Thanks!