Giter Site home page Giter Site logo

Comments (7)

jbigot avatar jbigot commented on June 27, 2024

See also https://gitlab.maisondelasimulation.fr/gysela-developpers/voicexx/-/issues/66

from ddc.

tpadioleau avatar tpadioleau commented on June 27, 2024
  • to_real -> coordinate, position ?
  • DiscreteCoordinate -> DiscreteElement
  • DiscreteVector -> ok
  • rcoord_type -> c_elem_type, c_element_type, continuous_element_type ?
  • dvect_type -> d_vect_type, discrete_vect_type, discrete_vector_type ?
  • ddom_type -> d_dom_type, discrete_dom_type, discrete_domain_type ?
  • rdim_type -> c_dim_type, c_dimension_type, continuous_dimension_type ?
  • mcoord_type -> d_elem_type, d_element_type, discrete_element_type ?
  • ddim_type -> d_dim_type, discrete_dim_type, discrete_dimension_type ?

from ddc.

tpadioleau avatar tpadioleau commented on June 27, 2024
  • discretization() -> discrete_space() ?

from ddc.

jbigot avatar jbigot commented on June 27, 2024

discretization() -> discrete_space() ?

👍

ddim_type -> d_dim_type, discrete_dim_type, discrete_dimension_type ?

👍 for discrete_dimension_type

DiscreteCoordinate -> DiscreteElement

👍

DiscreteVector -> ok

👍

I'd also propose to change:

  • UniformDiscretization -> UniformPointDiscretization or UniformPointSampling
  • NonUniformDiscretization -> NonUniformPointDiscretization or NonUniformPointSampling

dvect_type -> d_vect_type, discrete_vect_type, discrete_vector_type ?

👍 for discrete_vector_type

ddom_type -> d_dom_type, discrete_dom_type, discrete_domain_type ?

👍 for discrete_domain_type

mcoord_type -> d_elem_type, d_element_type, discrete_element_type ?

👍 for discrete_element_type

to_real -> coordinate, position ?

👍 for coordinate in case of a *PointDiscretization

rdim_type -> c_dim_type, c_dimension_type, continuous_dimension_type ?

👍 for continuous_dimension_type unless we can use different terms for the continuous and discrete cases...

rcoord_type -> c_elem_type, c_element_type, continuous_element_type ?

👍 for continuous_element_type, but maybe we can use coordinate_type for an element of a continuous space...

from ddc.

tpadioleau avatar tpadioleau commented on June 27, 2024

As discussed, there may be multiple attributes attached to a discrete coordinate. Some of them can be related to the underlying continous space like in the UniformPointDiscretization case. Then should we inject a type such as continuous_element_type ?

from ddc.

tpadioleau avatar tpadioleau commented on June 27, 2024

UniformPointDiscretization may be closer to the other names we already introduced ?

from ddc.

tpadioleau avatar tpadioleau commented on June 27, 2024

I tried UniformPointSampling in the end. Looks good to me.

from ddc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.