Inconsistent behaviour

[bdaniel7]

Inconsistent behaviour

[cezarypiatek]

Ad1. I need to check that, can you provide a sample solution?
Ad2. "Implement Clone metho" - I don't provide such functionality. You probably confused MappingGenerator with something else.

[bdaniel7]

Ad2. In the project wiki there is a paragraph

• Generate ICloneable interface implementation - with a gif.

[bdaniel7]

I added this project https://github.com/bdaniel7/MappingGeneratorTest

So if there is a ":" right after the class name, like when derived or implementing an interface, the Implement clone method menu doesn't appear.
If there is a space between class name and ":", the menu appears.

And Initialize with local values menu appears but doesn't generate anything,
Initialize with sample values menu appears and generates the dummy values.

[cezarypiatek]

Oh, sorry. I totally forgot that I implemented this clone-related feature 😄

Thanks for a sample solution, I will check that later and I will let you know.

[cezarypiatek]

I don't see any problem with "Implement clone" options, works fine in any "space" configuration.

Tested on Rider 2020.2.1

You can also trigger this action directly on the clone method signature:

[cezarypiatek]

"Initialize with local values" - this action is using only local variables and method parameters. It's not using enclosing type members. This is the current behavior.

[bdaniel7]

Ok, I'm getting the menu when I have the cursor on the class name. Previously I had the cursor just at the end of class name.
But when I try to invoke the action, the IDE freezes. I have to close it from Task Manager. I'm using Rider 2020.2.4

[cezarypiatek]

How large is your solution and how complex is the cloned class?

[bdaniel7]

Some classes have around 750 lines, including curly braces and empty lines. Other classes have 45 or 75 lines, with just 2 to 10 properties. And some IEquatable<> implementation.

[cezarypiatek]

does it hang on that sample solution too?

[bdaniel7]

Nope.

[cezarypiatek]

So I guess this is due to solution size. This problem is already reported here #115

I tried to profile MappinGenerator several times but I wasn't able to find anything suspicions. Without real example I'm not able to diagnose this problem.

There are a few async operations which are run synchronously, I need to rewrite it and we will see if that can help.

[bdaniel7]

Alright, in the meantime I will try a workaround.

[cezarypiatek]

@bdaniel7 might I ask you to test it once again using v1.19.452?

[bdaniel7]

First, the compilation for the entire solution became waaay slower - when using dotnet watch run.
Even when just a file is modified.
Which makes the CPU and the fans go crazy...
Then, I got all kinds of warnings that I didn't get before, and that I had to disable with VSTHRD200,VSTHRD103,VSTHRD002,VSTHRD110,VSTHRD003.

[cezarypiatek]

Thanks for quick reply. It's my mistake, the analyzers were referenced incorrectly, should be fixed in v1.19.454

[cezarypiatek]

I'm closing this issue. The case with performance can be tracked here #115