Is this a good way to extend cfndsl for project specific requirements?

[cfndsl]

Is this a good way to extend cfndsl for project specific requirements?

[stevenjack]

@yumpy I'd say that's a pretty good way of extending cfndsl for your needs, there's only a ref optimisations you could make such as:

  EC2_SecurityGroupEgress("#{name}Egress") {
      GroupId Ref(source)
      IpProtocol protocol
      FromPort port
      ToPort port
      DestinationSecurityGroupId destination
  }

  EC2_SecurityGroupIngress("#{name}Ingress") {
      GroupId destination
      IpProtocol protocol
      FromPort port
      ToPort port
      SourceSecurityGroupId Ref(source)
      SourceSecurityGroupOwnerId SG_OWNER_ID
    } 

Under the GroupId property do the reference there so when you pass in the names you don't have to wrap each one in a ref:

 EC2_SecurityGroupPermission("WebToDB1443", :sgWeb, :sgDB, "tcp", "1443")

Also, if you're creating a lot of security groups then you could DRY it up a little bit by doing the following:

sg_names = %w{sgWeb, sgDB}

sg_names.each do |sg_name|
  EC2_SecurityGroup(sg_name.to_sym) {
    GroupDescription sg_name
    VpcId VPC
    SecurityGroupIngress []
    SecurityGroupEgress []
  }
end

To loop through the the names in sg_names and create the groups.