Giter Site home page Giter Site logo

Comments (7)

mtausig avatar mtausig commented on May 25, 2024

How are external dependencies handled by this project? Right now, there do not appear to be any. Would a new one be acceptable?

from cfv.

lxp avatar lxp commented on May 25, 2024

Currently, there is no mechanism to manage external dependencies. However, there is also no hard-dependency yet, as most functionality works fine with just the Python standard library.
You can find the optional dependencies in the README: https://github.com/cfv-project/cfv/blob/master/README.md#optional
These functions simply do not work or use some other implementations, when they are not available.

One option would be to use setuptools for dependencies, as it is already used anyway. However, I am not sure, if it is easy to specify optional dependencies.
What other options are there to manage dependencies in Python?

from cfv.

mtausig avatar mtausig commented on May 25, 2024

What other options are there to manage dependencies in Python?

We could add a requirements.txt file whose contents gets installed by pip.

from cfv.

lxp avatar lxp commented on May 25, 2024

We could add a requirements.txt file whose contents gets installed by pip.

The project is also distributed via PyPI, so the dependencies should be automatically pulled when doing a pip install cfv. Does this work, when we just have a requirements.txt?

from cfv.

mtausig avatar mtausig commented on May 25, 2024

You have to put them in setup.py as well iirc.
If you are not opposed to having a dependency, I will give it a shot.

As an alternative, there would be a pure-python blake2b implementation, but that is of course not competitive performance-wise.

from cfv.

lxp avatar lxp commented on May 25, 2024

I am not against adding dependencies, especially, if there are some good libraries for the job.
Also, performance is a relevant factor for cfv.
Please keep in mind that the library should be available via PyPI, run on Python 2.7/3 and there are bonus points, if it is already available as a Debian package, as we want to have a cfv Debian package again in the future too.

from cfv.

lxp avatar lxp commented on May 25, 2024

Since Python 3.6 hashlib suports BLAKE2 [1]. If the hashlib support is enough for supporting GNU coreutils b2sum, then I would opt for using it.

In any case, please consider implementing it in cfv 3.x (currently the python3 branch), as no feature releases are planned for cfv 2.x (currently the master branch).

[1] https://docs.python.org/3/library/hashlib.html#blake2

from cfv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.