Comments (10)
I'm going to start work on this today or tomorrow since it seems to be a blocker for merging anything new into ghost.
from downsize.
Sorry, I've been flat out. I'll have a think about the best way to tackle this tonight — let me know if you get started on it, so we don't end up double-handling. :)
from downsize.
Bump :) Would looove for this to be resolved even if it's just a temporary workaround with the condition that I remove it when Ghost no longer needs it 😉
from downsize.
i'll take another look shortly.
from downsize.
next on my plate if the cleanup (#16) goes in! :)
from downsize.
It looks like the two cases this would have to deal with are markdown output matching:
<p><img src="..." ...></p>
and
<p><a href="#"><img src=".."></a></p>
from downsize.
It currently works for video as well I believe.
from downsize.
oh good point, thanks!
from downsize.
I want to extend the parser to support tag types rather than regex it. If we merge this we should have a followup to do it properly. :)
from downsize.
I think you can close this issue now. I have a plan to reproduce this feature inside Ghost, so that we can upgrade to a newer version of downsize. I don't think it's really the job of downsize to maintain what was a bug.
Also, by having it internally in Ghost, we can properly manage deprecating it once we have equivalent functionality done in the right way.
from downsize.
Related Issues (16)
- create a system to count by blocks HOT 6
- trailing tags in character mode. HOT 2
- downsize seems does not handle Asian languages HOT 15
- improve documentation HOT 2
- downsize doesn't handle invalid html HOT 6
- Option to remove scripts and embeds HOT 3
- dupe functionality introduced with round=true api HOT 4
- add round:true api for rounding with good sentence default contextualTags. HOT 1
- Add travis HOT 1
- Entity Counts Towards the Word or Character Count
- Entities and smart quotes cause erroneous results
- Truncation Breaks if HTML Comment Contains Quotes
- downsize doesn't appear to correctly handle zero HOT 2
- Tags with single quotes inside double quotes doesn't get parsed/truncated correctly according to the limit (by words/characters) HOT 1
- Trailing empty tags occur.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from downsize.