Giter Site home page Giter Site logo

Comments (10)

adam-zethraeus avatar adam-zethraeus commented on July 16, 2024

I'm going to start work on this today or tomorrow since it seems to be a blocker for merging anything new into ghost.

from downsize.

cgiffard avatar cgiffard commented on July 16, 2024

Sorry, I've been flat out. I'll have a think about the best way to tackle this tonight — let me know if you get started on it, so we don't end up double-handling. :)

from downsize.

ErisDS avatar ErisDS commented on July 16, 2024

Bump :) Would looove for this to be resolved even if it's just a temporary workaround with the condition that I remove it when Ghost no longer needs it 😉

from downsize.

adam-zethraeus avatar adam-zethraeus commented on July 16, 2024

i'll take another look shortly.

from downsize.

adam-zethraeus avatar adam-zethraeus commented on July 16, 2024

next on my plate if the cleanup (#16) goes in! :)

from downsize.

adam-zethraeus avatar adam-zethraeus commented on July 16, 2024

It looks like the two cases this would have to deal with are markdown output matching:

<p><img src="..." ...></p>
and
<p><a href="#"><img src=".."></a></p>

from downsize.

ErisDS avatar ErisDS commented on July 16, 2024

It currently works for video as well I believe.

from downsize.

adam-zethraeus avatar adam-zethraeus commented on July 16, 2024

oh good point, thanks!

from downsize.

cgiffard avatar cgiffard commented on July 16, 2024

I want to extend the parser to support tag types rather than regex it. If we merge this we should have a followup to do it properly. :)

from downsize.

ErisDS avatar ErisDS commented on July 16, 2024

I think you can close this issue now. I have a plan to reproduce this feature inside Ghost, so that we can upgrade to a newer version of downsize. I don't think it's really the job of downsize to maintain what was a bug.

Also, by having it internally in Ghost, we can properly manage deprecating it once we have equivalent functionality done in the right way.

from downsize.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.