Lots of errors on job nr. 1 / events block

[sebastianelsner]

Lots of errors on job nr. 1 / events block

[timurhai]

Now it is an error.

cgru/afanasy/src/render/taskprocess.cpp

Line 127 in b6de019

if (m_cmd.size() == 0)

There should be an empty commands. Empty command can happen due some error in a service python code.
But now, check for skipping goes first:

cgru/afanasy/src/render/taskprocess.cpp

Line 118 in b6de019

if (m_service->skipTask())

So, if you want to skip a command launch you should set self.skip_task = True:

cgru/afanasy/python/services/service.py

Line 195 in b6de019

def skipTask(self):

[timurhai]

This was discussed here:
#590

[sebastianelsner]

yep, I understand, thanks for posting issue #590, that was the one I was looking for! BUT does the change of

cgru/afanasy/src/render/taskprocess.cpp

Line 129 in b6de019

m_update_status = af::TaskExec::UPFailedToStart;

make event tasks fail, because they have a empty cmd, no?? Or is this something that is just happening for me and the reason is something else?

[timurhai]

Latest commit fix common event class:
b6de019
There is 3.4.0 in master branch now, it is under develop.
But we use it in production.

[sebastianelsner]

Got it, we need to port some of your changes as well.