Disk cache can exceed 60MB

[chandevel]

Disk cache can exceed 60MB

[floens]

Clover uses two kinds of file loading:

The first is Volley that is used to load thumbnails and json data. This works by loading the data into memory and when it's done loading put in in a file (cache/volley). Volley currently purges files from memory after the size has exceeded 8MB, and purges files from disk if that exceeds 10MB. Volley also limits the keeps the amount of files under 250. (250 thumbnails are almost always under 10MB).

And there is the FileCache. FileCache straight up loads files from the network to the disk, and does not keep the files into memory. FileCache is used when loading full size images. These images can get up to 8MB in size. Lower end devices cannot load these files into memory so that's why it is loading directly tot the disk. FileCache keeps the disk size under 50MB.

Now the total size shouldn't exceed 60MB, but due to a bug in Ion not keeping it's own cache down (Ion is used in FileCache) it may exceed 60MB. The current workaround is to purge the Ion cache on startup.

I'm going to remove Ion as a file loader and use something that loads files from the network and only that. I chose Ion initially because I wanted to load bitmaps with it too, but that's unnecessary now.

I'll keep this issue open until Ion is replaced and the cache size stays below 60MB.

[tadev]

Thanks for the explanation. Although an option in the settings to disable disk caching altogether would be awesome, if you got the time 👍 keep it up!

[floens]

Disabling the disk caching is impossible. Why would you want it disabled?

[tadev]

No writes to internal SD in my case prolongs the lifespan. Also, maybe caching in memory could be an option for devices with more RAM. Maybe adding a wrapper over the caching stuff that allows to choose either file cache or ram cache?

(Also no traces of 4chin on storage)

[floens]

Replaced the image loader with okhttp