Giter Site home page Giter Site logo

Comments (4)

chandlerprall avatar chandlerprall commented on July 18, 2024

Absolutely - what do you think about leaving out the clone() call altogether? If you want to store the vectors it's left to the dev to explicitly clone?

In fact I've thought about doing this for most of the vectors passed to the callbacks, but I'm afraid that kind of thing is hard to document and ensure everyone understands that those are flyweights.

I suppose some simple testing would show if making such a change yields any perceivable increase in performance.

from physijs.

 avatar commented on July 18, 2024

I only added in clone() because _temp2 overwrites _temp1, but yeah, as long as the vectors in the callback dont get overwritten afterwards, it'll work!

from physijs.

chandlerprall avatar chandlerprall commented on July 18, 2024

Should be good now :) It is using flyweights so make sure to clone() if you end up storing the values.

from physijs.

 avatar commented on July 18, 2024

sweet, thanks!

from physijs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.