Comments (8)
Hi, the duration field is optional and according to the code only merged or closed PRs got the duration field. https://github.com/change-metrics/monocle/blob/master/src/Lentille/GitHub/Utils.hs#L183
from monocle.
is this really correct? does it matter for the events above that PR is closed or merged. Or do you mean that duration will be added to these events when PR is closed?
from monocle.
Yes when the PR is merged or closed then the duration is added to the Change object and related Event objects.
from monocle.
Maybe I am wrong but it will be less complex to add duration at the time we create events. Plus, as I mentioned above, there are benefits in having this information even if PR is not merged yet - what is the downside ?. I can be wrong of course :)
from monocle.
Yes we could set the duration for not merged/closed Changes however the duration won't be accurate most of the time if the Change is not merged or closed. That sounds more logical to let the data consumer (eg. the Monocle UI) figures out the (change in-progress) duration at query time. Could the scripted fields help for your use case https://www.elastic.co/guide/en/elasticsearch/reference/current/search-fields.html#script-fields ? What is the use case ?
from monocle.
The metric is PR pickup time - when there is a first comment. Probably I can filter by only merge/closed PRs but I feel this it does not matter what will happen with PR. Also I think the time should be consistent because I understand we measure the time between PR creation and comment and PR creation time will be the same irrespective of whether you merged it or not. No?
from monocle.
The duration
on the Event
object is the same as the duration
on a Change
object.
Perhaps what you would like is a two new fields:
- delay_for_first_comment
- delay_for_first_review
These new fields could be added to Change
objects ?
from monocle.
For me one field will be enough - it does not matter whether it was a comment or review (not sure why GitHub has two different events)
from monocle.
Related Issues (20)
- Target branch in the ChangeMergedEvent HOT 3
- Bump the ElasticSearch version to 8.X
- Question: Problems with running it using docker compose
- Add merge_commit_sha to Change event HOT 2
- Incorrect commit time in ChangeCommitPushedEvent HOT 4
- Github crawler - changedFiles will be removed. Use changedFilesIfAvailable instead
- Question: After using the latest image - 2 Nov 2023 - health check returns unhealthy. HOT 2
- Since 1.10.0 search user feature is broken
- Support a groups attribute in any Ident attribute HOT 16
- Crawler failed to load when using loop_delay_sec HOT 2
- Feedback on clicked links
- Corporate proxy settings for crawler HOT 4
- GitHub Project LLVM Failing and not indexing HOT 14
- Errors when running crawler behind corporate proxy HOT 17
- Monocle k8s deployment, api service throws network error when accessing via load balancer service HOT 3
- Display "name" instead of account name HOT 2
- Crawler stopped importing data HOT 17
- Updating Ident HOT 2
- [Question]: Can you clarify when updated_at field modified in "Change" event (in relation to changing from draft : false to draft:" HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monocle.