Friendly_id and impressionist 1.0.1 not recording impressionable id

[charlotte-ruby]

Friendly_id and impressionist 1.0.1 not recording impressionable id

[pekpon]

I do this, in the controller:

def show
@Article = Article.find(params[:id])
impressionist(@Article)
end

and its ok!

Same problem here. Any ideas?

before_filter :only => [:show] do |controller|
params[:id] = @video.id
end

impressionist :actions => [:show]

Kind of ugly but it works now.

[pekpon]

I have the same problem in Rails 3.2.0...

[JapArt]

I have the same problem with Rails 3.2.1

[andreydjason]

Yep, having the same issue here, using friendly_id with slugged. Rails 3.1.1

UPDATE
Well, my option was to change the behavior of impressionist.
First changed the column impressionable_id to string.
Modified impressionable.rb, in line 13 I added:

if self.respond_to?(:friendly_id)
  has_many :impressions, :as => :impressionable, :finder_sql => Proc.new {
    %Q{
      SELECT `impressions`.* FROM `impressions` WHERE `impressions`.`impressionable_id` = '#{slug}' AND `impressions`.`impressionable_type` = '#{self.class.to_s}'
    }
  }
else
  has_many :impressions, :as => :impressionable
end

This is not the best workaround, but works for me, maybe because I'm using impressionist in a "default" way for most of my models and controllers, but maybe not work in other situations. If someone know a better way to do that, please tell us :)

Another caveat, the specific SQL above sometimes return wrong, if for example you do @object.impressions.to_sql will return a wrong SQL, BTW @object.impressions will return the correct objects.

UPDATE2
The impressionist_count method broken with "select", this is baaad...
For now I've commented the lines 47 to 49 (the line numbers change with the add above) in the impressionist_count method to work for me, while cant find a workaround.

UPDATE3
For this situation, it needs to change to the impressionist_count method, set imps.all.size to imps.count (I dont know if I'm right, but this improve the SQL too)

Maybe someone find a better way to improve all this "behaviors" that are really dirty... thanks

[andreydjason]

thanks

[JapArt]

Works for me too. Thanks!