Comments (8)
I do this, in the controller:
def show
@Article = Article.find(params[:id])
impressionist(@Article)
end
and its ok!
from impressionist.
Same problem here. Any ideas?
from impressionist.
before_filter :only => [:show] do |controller|
params[:id] = @video.id
end
impressionist :actions => [:show]
Kind of ugly but it works now.
from impressionist.
I have the same problem in Rails 3.2.0...
from impressionist.
I have the same problem with Rails 3.2.1
from impressionist.
Yep, having the same issue here, using friendly_id with slugged. Rails 3.1.1
UPDATE
Well, my option was to change the behavior of impressionist.
First changed the column impressionable_id
to string.
Modified impressionable.rb
, in line 13 I added:
if self.respond_to?(:friendly_id)
has_many :impressions, :as => :impressionable, :finder_sql => Proc.new {
%Q{
SELECT `impressions`.* FROM `impressions` WHERE `impressions`.`impressionable_id` = '#{slug}' AND `impressions`.`impressionable_type` = '#{self.class.to_s}'
}
}
else
has_many :impressions, :as => :impressionable
end
This is not the best workaround, but works for me, maybe because I'm using impressionist in a "default" way for most of my models and controllers, but maybe not work in other situations. If someone know a better way to do that, please tell us :)
Another caveat, the specific SQL above sometimes return wrong, if for example you do @object.impressions.to_sql
will return a wrong SQL, BTW @object.impressions
will return the correct objects.
UPDATE2
The impressionist_count
method broken with "select", this is baaad...
For now I've commented the lines 47 to 49 (the line numbers change with the add above) in the impressionist_count
method to work for me, while cant find a workaround.
UPDATE3
For this situation, it needs to change to the impressionist_count
method, set imps.all.size
to imps.count
(I dont know if I'm right, but this improve the SQL too)
Maybe someone find a better way to improve all this "behaviors" that are really dirty... thanks
from impressionist.
thanks
from impressionist.
Works for me too. Thanks!
from impressionist.
Related Issues (20)
- is it possible to have 2 types of counter_cache for the same model?
- PG::CharacterNotInRepertoire exception HOT 1
- Track all pages HOT 1
- How to filter most viewed posts in a category.
- Rails 6.0.0 Deprecation warnings HOT 7
- Rack session id is no longer allow to be coerced to string HOT 2
- What does missing a widget mean?
- Undefined method `cookie_value' for string in ImpressionistCrontroller HOT 8
- How to count impressions on an object per a number o days.
- Index Blob size in Params Issue HOT 1
- How to create model callbacks? HOT 1
- NoMethodError (undefined method `cookie_value' for nil:NilClass) in API only Rails project HOT 17
- Is it possible to use Impressionist with GraphQL?
- NoMethodError (undefined method `id' for {"init"=>true}:Hash):
- Rails 7 - uninitialized constant Impressionist::Engine::ImpressionistController (NameError) HOT 3
- Userid is coming as 0, 1, 2 etc HOT 1
- Support for rails 7? HOT 1
- How to change impressionable_id: 0 to somthing else
- New error upon upgrading to Rails 5.2.8.1: Tried to load unspecified class: ActiveSupport::HashWithIndifferentAccess
- How to change IP before save? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from impressionist.