Giter Site home page Giter Site logo

scale added and corrected about fretboarder HOT 3 CLOSED

sugizo avatar sugizo commented on August 24, 2024
scale added and corrected

from fretboarder.

Comments (3)

cheap-glitch avatar cheap-glitch commented on August 24, 2024

seems blues minor and blues major is incorrect you define it as hexatonic (6th tone) while it should goes to pentatonic (5th tone)

The name "blues scale" most commonly refers to the hexatonic variants (pentatonic + diminished fifth): https://en.wikipedia.org/wiki/Blues_scale#Hexatonic, so this is indeed correct.

all the positions defined in music.js will not use when user select symmetrical tuning

I don't think this matters much, if the positions are useless or nonsensical, the user will just ignore that feature. Though I agree the position selector should be hidden in that case.

nice to have more scale pentatonic variant, hexatonic variant, heptatonic variant, octatonic variant like bebop, etc

Feel free to open a new PR to add those!

from fretboarder.

sugizo avatar sugizo commented on August 24, 2024

I don't think this matters much, if the positions are useless or nonsensical, the user will just ignore that feature. Though I agree the position selector should be hidden in that case.

position on guitar is great feature, but can't use it if the user change the tuning
e.g. https://fretboarder.app
A minor pentatonic scale on guitar '6 strings' with 'Drop D' tuning '1st position', can't see the tone 'C' on string 6th (bottom)

some idea
perhaps can make condition about the position (not recommended because everytime you add new tuning, you must add new position)
or
make it adaptable, by add user text input to add which fret on fretboard that user want to focus at during learning the scale e.g. A minor pentatonic scale on guitar '6 strings' with 'Drop D' tuning '1st position', user can input from fret 5 till fret 10, so that user can clearly see the tone 'C' on string 6, but user will see tone 'G with same octave' double on string 5 fret 10 and 4 fret 5

note
not sure which is good, since another tuning have another aim itself, e.g. open tuning is for rhythm guitarist playing chord efficiently by using 1 finger to make a chord, e.g. open D

from fretboarder.

sugizo avatar sugizo commented on August 24, 2024

The name "blues scale" most commonly refers to the hexatonic variants (pentatonic + diminished fifth): https://en.wikipedia.org/wiki/Blues_scale#Hexatonic, so this is indeed correct.

yes, you right, my bad, never thought blues major and blues minor also exist on hexatonic

Feel free to open a new PR to add those!

please review it first (already group the scale with it's mode)
perhaps can use the html select optgroup for the scale with it's mode
e.g.
<optgroup label="Major Pentatonic">

ref
https://en.wikipedia.org/wiki/Mode_(music)#Other_types

thanks

	// SCALES

	// Pentatonics
	'maj5':         { intervals: [2,  4,  7,  9],             name: 'major pentatonic'          },
	'egpt':         { intervals: [2,  5,  7, 10],             name: 'egyptian'                  },
	'bmin5':        { intervals: [3,  5,  8, 10],             name: 'blues minor pentatonic'    },
	'bmaj5':        { intervals: [2,  5,  7,  9],             name: 'blues major pentatonic'    },
	'min5':         { intervals: [3,  5,  7, 10],             name: 'minor pentatonic'          },

	'in':           { intervals: [1,  5,  7,  8],             name: 'in'                        },
	'hrjs':         { intervals: [4,  6,  7, 11],             name: 'hirajoshi'                 },
	'iwt':          { intervals: [1,  5,  6, 10],             name: 'iwato'                     },

	'ins':          { intervals: [1,  5,  7, 10],             name: 'insen'                     },

	// Hexatonics
	'maj6':         { intervals: [2,  4,  5,  7,  9],         name: 'major hexatonic'           },
	'min6':         { intervals: [2,  3,  5,  7, 10],         name: 'minor hexatonic'           },

	'bmaj6':        { intervals: [2,  3,  4,  7,  9],         name: 'blues major hexatonic'     },
	'bmin6':        { intervals: [3,  5,  6,  7, 10],         name: 'blues minor hexatonic'     },

	'augmt':        { intervals: [3,  4,  7,  8, 11],         name: 'augmented'                 },

	'blues':        { intervals: [3,  5,  6,  7, 10],         name: 'blues'                     },

	'prmts':        { intervals: [2,  4,  6,  9, 10],         name: 'prometheus'                },

	'3tone':        { intervals: [1,  4,  6,  7, 10],         name: 'tritone'                   },

	'wtone':        { intervals: [2,  4,  6,  8, 10],         name: 'whole tone'                },

	// Heptatonic
	'ion':          { intervals: [2,  4,  5,  7,  9, 11],     name: 'natural major'             },
	'dor':          { intervals: [2,  3,  5,  7,  9, 10],     name: 'dorian'                    },
	'phry':         { intervals: [1,  3,  5,  7,  8, 10],     name: 'phrygian'                  },
	'lyd':          { intervals: [2,  4,  6,  7,  9, 11],     name: 'lydian'                    },
	'mix':          { intervals: [2,  4,  5,  7,  9, 10],     name: 'mixolydian'                },
	'aeo':          { intervals: [2,  3,  5,  7,  8, 10],     name: 'natural minor'             },
	'locr':         { intervals: [1,  3,  5,  6,  8, 10],     name: 'locrian'                   },

	'asmelm':       { intervals: [2,  3,  5,  7,  9, 11],     name: 'ascending melodic minor'   },
	'phry#6':       { intervals: [1,  3,  5,  7,  9, 10],     name: 'phrygian #6'               },
	'lydaug':       { intervals: [2,  4,  6,  8,  9, 11],     name: 'lydian augmented'          },
	'lyddom':       { intervals: [2,  4,  6,  7,  9, 10],     name: 'lydian dominant'           },
	'aeodom':       { intervals: [2,  4,  5,  7,  8, 10],     name: 'aeolian dominant'          },
	'loc#2':        { intervals: [2,  3,  5,  6,  8, 10],     name: 'locrian #2'                },

	'dharmaj':      { intervals: [1,  4,  5,  7,  8, 11],     name: 'double harmonic major'     },
	'lyd#2#6':      { intervals: [3,  4,  6,  7, 10, 11],     name: 'lydian #2 #6'              },
	'uphrg':        { intervals: [1,  3,  4,  7,  8,  9],     name: 'ultraphrygian'             },
	'hunga':        { intervals: [2,  3,  6,  7,  8, 11],     name: 'hungarian'                 },
	'orient':       { intervals: [1,  4,  5,  6,  9, 10],     name: 'oriental'                  },
	'ion#2#5':      { intervals: [3,  4,  5,  8,  9, 11],     name: 'ionian #2 #5'              },
	'locbb3bb7':    { intervals: [1,  2,  5,  6,  8,  9],     name: 'locrian bb3 bb7'           },

	'harmaj':       { intervals: [2,  4,  5,  7,  8, 11],     name: 'harmonic major'            },
	'dorb5':        { intervals: [2,  3,  5,  6,  9, 10],     name: 'dorian b3'                 },
	'phrgb4':       { intervals: [1,  3,  4,  7,  8, 10],     name: 'phrygian b4'               },
	'lydb3':        { intervals: [2,  3,  6,  7,  9, 11],     name: 'lydian b3'                 },
	'mixob2':       { intervals: [1,  4,  5,  7,  9, 10],     name: 'mixolydian b2'             },
	'lydaug#2':     { intervals: [3,  4,  6,  8,  9, 11],     name: 'lydian augmented #2'       },
	'locbb7':       { intervals: [1,  3,  5,  6,  8,  9],     name: 'locrian bb7'               },

	'harmin':       { intervals: [2,  3,  5,  7,  8, 11],     name: 'harmonic minor'            },
	'loc13':        { intervals: [1,  3,  5,  6,  9, 10],     name: 'locrian 13'                },
	'ion#5':        { intervals: [2,  4,  5,  8,  9, 11],     name: 'ionian #5'                 },
	'dor#11':       { intervals: [2,  3,  6,  7,  9, 10],     name: 'dorian #11'                },
	'phrydom':      { intervals: [1,  4,  5,  7,  8, 10],     name: 'phrygian dominant'         },
	'lyd#2':        { intervals: [3,  4,  6,  7,  9, 11],     name: 'lydian #2'                 },
	'alt':          { intervals: [1,  3,  4,  6,  8, 10],     name: 'altered'                   },

	'neamin':       { intervals: [1,  3,  5,  7,  8, 11],     name: 'neapolitan minor'          },
	'gypsy':        { intervals: [2,  3,  6,  7,  8, 10],     name: 'gypsy'                     },

	'neamaj':       { intervals: [1,  3,  5,  7,  9, 11],     name: 'neapolitan major'          },

	'eni':          { intervals: [1,  4,  6,  8, 10, 11],     name: 'enigmatic'                 },

	'flam':         { intervals: [1,  4,  5,  7,  8, 11],     name: 'flamenco'                  },

	'hungmaj':      { intervals: [3,  4,  6,  7,  9, 10],     name: 'hungarian major'           },

	'majloc':       { intervals: [2,  4,  5,  6,  8, 10],     name: 'major locrian'             },

	'pers':         { intervals: [1,  4,  5,  6,  8, 11],     name: 'persian'                   },

	'ukrdor':       { intervals: [2,  3,  6,  7,  9, 10],     name: 'ukranian dorian'           },

	// Octatonic
	'hdim':         { intervals: [1,  3,  4,  6,  7,  9, 10], name: 'diminished (half/whole)'   },
	'wdim':         { intervals: [2,  3,  5,  6,  8,  9, 11], name: 'diminished (whole/half)'   },

	'majbeb':       { intervals: [2,  4,  5,  7,  8,  9, 11], name: 'major bebop'               },
	'hminbeb':      { intervals: [2,  3,  5,  7,  8, 10, 11], name: 'harmonic minor bebop'      },

	'dombeb':       { intervals: [2,  4,  5,  7,  9, 10, 11], name: 'dominant bebop'            },
	'locbeb':       { intervals: [1,  3,  5,  6,  7,  8, 10], name: 'locrian bebop'             },
	'dorbeb':       { intervals: [2,  3,  4,  5,  7,  9, 10], name: 'dorian bebop'              },

	'melminbeb':    { intervals: [2,  3,  5,  7,  8,  9, 11], name: 'melodic minor bebop'       },

	'phrydombeb':   { intervals: [1,  4,  5,  7,  8, 10, 11], name: 'phrygian dominant bebop'   },

	// Octatonic
	'chromatic':    { intervals: [1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11], name: 'chromatic' },

from fretboarder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.