SuppressionCommentFilter does not suppress StrictDuplicateCode Warnings

[romani]

SuppressionCommentFilter does not suppress StrictDuplicateCode Warnings

[ychulovskyy]

I'll work on it.

[mkordas]

Hi Iurii, StrictDuplicateCode has been removed from Checkstyle, so this
issue can be just closed.
24-12-2014 23:36 użytkownik "Yuriy Chulovskyy (Iurii Chulovskyi)" <
[email protected]> napisał:

I'll work on it.

—
Reply to this email directly or view it on GitHub
#26 (comment)
.

[ychulovskyy]

@mkordas Thanks for update!
@romani Could you please close the issue?

[romani]

@ychulovskyy, here problem is not about a particular Check , you can substitude StrictDuplicateCheck to another Check that is not running under TreeWalker. Such Checks are called FileSet checks.

[ychulovskyy]

Ok, I've found the issue.
Checker.process do the following:

        for (final FileSetCheck fsc : mFileSetChecks) {
            // They may also log!!!
            fsc.finishProcessing();
            fsc.destroy();
        }

Need to do the same but in separate loops. Otherwise destroy method will release file context and next check doesn't have it. As a result - filter.accept() will return true and we will see the audit message.
Will fix and create test in a few days.

[romani]

@ychulovskyy , are you planing to provide fix or our team should do that ?

[ychulovskyy]

@romani I'll provide till EOW. It's not so important since there is no more checks that do processing in finishProcessing() method. Only StrictDuplicateCodehad it.
So, need to think how to test the fix.

[romani]

that solution is accepted, but #820 is created to fix that conceptual problem.

fix is merged, will be in 6.5