Giter Site home page Giter Site logo

Comments (2)

romani avatar romani commented on June 15, 2024

@HuGanghui , please update issue description and title ... I do not understand what is "current filter".
If you mean SupprresionPatchFilter, yes we need to test how it works on Checks from TreeWalker. User might not use SupprresionPatchXpathFilter. But realistically there will be both filters in use almost always so we need to know how they works in all combinations.
As I mentioned at #7 (comment), Checker filter might suppress all that passed from Treewalker filter, so we need to teach SupprresionPatchFilter how to pass all violations from certain Checks.

Please create UT cases where two filters are in use and how it will work on java related Check (that use AST).
we can create new package bothpatchfilters at https://github.com/checkstyle/patch-filters/tree/master/src/test/resources/com/puppycrawl/tools/checkstyle/filters. Please do,

it will be much better than diff report. Diff report is good then we know how it works on certain cases and we want to explore more real life usecases. We are not ready for exploration now as there are a lot of cases we can simply make ourself.

from patch-filters.

HuGanghui avatar HuGanghui commented on June 15, 2024

The fixes were solved in #285.

from patch-filters.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.