Comments (2)
@HuGanghui , please update issue description and title ... I do not understand what is "current filter".
If you mean SupprresionPatchFilter, yes we need to test how it works on Checks from TreeWalker. User might not use SupprresionPatchXpathFilter. But realistically there will be both filters in use almost always so we need to know how they works in all combinations.
As I mentioned at #7 (comment), Checker filter might suppress all that passed from Treewalker filter, so we need to teach SupprresionPatchFilter how to pass all violations from certain Checks.
Please create UT cases where two filters are in use and how it will work on java related Check (that use AST).
we can create new package bothpatchfilters
at https://github.com/checkstyle/patch-filters/tree/master/src/test/resources/com/puppycrawl/tools/checkstyle/filters. Please do,
it will be much better than diff report. Diff report is good then we know how it works on certain cases and we want to explore more real life usecases. We are not ready for exploration now as there are a lot of cases we can simply make ourself.
from patch-filters.
The fixes were solved in #285.
from patch-filters.
Related Issues (20)
- Implement checkNameForContextStrategyByTokenOrAncestorSet HOT 30
- Add more details in pom.xml and publish patch-filters to maven repository? HOT 3
- List checks that will miss some violations when only use supportContextStrategyChecks property HOT 3
- Add more javadoc annotation in import private methods HOT 1
- Rename SuppressionPatchXpathFilter to SuppressionJavaPatchFilter HOT 4
- Reorganize test resources by check module HOT 4
- Update checkstyle dependency from 8.33 to 8.35 HOT 1
- Make checkNamesForContextStrategyByTokenOrAncestorSet and checkNamesForContextStrategyByTokenOrParentSet work together HOT 1
- Update README.md to add checkNamesForContextStrategyByTokenOrAncestorSet property HOT 1
- FUTURE: Checks under neverSuppressedChecks group should give more precise violations
- FUTURE: Gather ideas for column strategy HOT 4
- FUTURE: Combine checkNamesForContextStrategyByTokenOrParentSet and checkNamesForContextStrategyByTokenOrAncestorSet properties
- upgrade to Checkstyle 10.4 HOT 3
- upgrade to checkstyle 10.3.3 HOT 1
- upgrade to checkstyle 10.3.4 HOT 1
- Report on files being validated against HOT 7
- Share in documentaiton ability to validate few last commits
- patch-filters doesn't work on Windows OS HOT 9
- Missing Generate Patch Tests HOT 3
- Patch File doesn't include Unstaged Changes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patch-filters.