Movement of code is counted as a new change

[checkstyle]

Movement of code is counted as a new change

[rdiachenko]

@HuGanghui please give 4 patches which cover 4 cases above. Put those patches here in a code block. No pull requests are required for now, we need to think how to deal with those cases first. Please think about it as well and provide your thoughts in a comment.

[HuGanghui]

1. MoveWithNoChanges

diff --git a/src/main/java/MoveMent/Test.java b/src/main/java/MoveMent/Test.java
index f76f4e8..aa50d00 100644
--- a/src/main/java/MoveMent/Test.java
+++ b/src/main/java/MoveMent/Test.java
@@ -4,18 +4,6 @@ public class Test {
     public void Test() {
         System.out.println();
         System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println("11111111111111111111");
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
     }
 
 
@@ -50,6 +38,18 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println("11111111111111111111");
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
     }
 

[HuGanghui]

2. MoveWithMinorChange

diff --git a/src/main/java/MoveMent/Test.java b/src/main/java/MoveMent/Test.java
index f76f4e8..2138d85 100644
--- a/src/main/java/MoveMent/Test.java
+++ b/src/main/java/MoveMent/Test.java
@@ -5,17 +5,6 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
-        System.out.println();
-        System.out.println("11111111111111111111");
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
     }
 
 
@@ -50,6 +39,17 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println("11111111111111111111122222222222222");
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
     }
 
 

[HuGanghui]

3. MoveWithOneAddition

diff --git a/src/main/java/MoveMent/Test.java b/src/main/java/MoveMent/Test.java
index f76f4e8..f250232 100644
--- a/src/main/java/MoveMent/Test.java
+++ b/src/main/java/MoveMent/Test.java
@@ -5,17 +5,6 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
-        System.out.println();
-        System.out.println("11111111111111111111");
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
     }
 
 
@@ -50,6 +39,18 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println("11111111111111111111");
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println("444444444444444444444");
     }
 
 

[HuGanghui]

4. MoveWithOneDeletion

diff --git a/src/main/java/MoveMent/Test.java b/src/main/java/MoveMent/Test.java
index f76f4e8..261805a 100644
--- a/src/main/java/MoveMent/Test.java
+++ b/src/main/java/MoveMent/Test.java
@@ -5,17 +5,6 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
-        System.out.println();
-        System.out.println("11111111111111111111");
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
-        System.out.println();
     }
 
 
@@ -50,6 +39,16 @@ public class Test {
         System.out.println();
         System.out.println();
         System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
+        System.out.println();
     }
 

[HuGanghui]

@rdiachenko I think If users move these code, then these code can be considered as new code, so it is ok for JGit to interpret the above cases as DELETE and INSERT.

[rdiachenko]

We won't do this for now as it would require to dig into jgit code and update it. The update itself (introduce a kind of MOVE state) might require a lot of investigation, might be error prone and very time consuming.