~ in version string breaks git caching

[chef]

~ in version string breaks git caching

[sethvargo]

@jessereynolds I would much prefer a Pull Request that removes all invalid characters, rather than just ~. I realize this is the only problem in your scope, but this will likely come up again with a different character.

[sethvargo]

Alternatively, we could generate a SHA for the tag instead. So, build it the same, but then SHA that value and use it for the tag.

[sethvargo]

In either case, this will invalidate all existing git caches. That's fine, but something we will need to make note of in the release notes.

[seth]

The downside of putting the digest of the version into the tag is that human debugging of the cache becomes much harder. If we can convince ourselves that there is a reasonably small set of illegal characters, it might be worth going that route.

For my use, since I don't make funny version numbers, going to SHA for version in tag is a net loss.

[sethvargo]

@seth yup - @schisamo and I discussed that this morning. I think I would prefer something like:

tag = version.gsub(/[SOME_MAGICAL_REGEX_OF_VALID_CHARACTERS]+/, '-')

AKA, replace all "bad" version characters with a valid one, logging a debug or warn message when doing so.

[seth]

+1

[jessereynolds]

Great! I'll give that a shot.

[jessereynolds]

Hmmm, it seems I must have been running an older version of omnibus when I encountered the above error. With current master I cannot reproduce the error. The reason is that the tag is now generated just from software.name and the version string doesn't come into it at all.