Comments (1)
It checks for the best practices by default. Particularly, these: https://cbea.ms/git-commit/.
It is helpful but I recognize that many people don't know how to write good commits so I've deliberately put the check into a separate workflow that is non-voting (not required for merging PRs).
It is supposed to be annoying but I think it's a good idea to add some links to the job summary from my articles collection, and maybe some more words...
It's also useful to have the gitlint
plugin integrated into one's editor of choice where they write commit messages (since it's the earliest point when the messages can be corrected).
In CI, the check only runs on PRs since it's pointless to report failures after the commits are already in the main branch. So it does attempt to let people, who care about this stuff, improve their commit messages while remaining non-invasive.
By the way, the job summary output is supposed to be easier to consume: https://github.com/cherrypy/cheroot/actions/runs/5032348262#summary-13629108128.
P.S. Obviously, the maintainers aren't expected to always fix such linting violations from other contributors. I wonder if it'd be useful to make the automation react to a label like give-up-on-nice-commits
. Though, having the error visual may hint to the merge actor that maybe they need to select a "squash" option and write one nice message rather than using a real/natural merge commit.
from cheroot.
Related Issues (20)
- setuptools_scm_git_archive is obsolete HOT 1
- ssl.SSLZeroReturnError exception on startup with builtin ssl backend python 3.8 or above HOT 14
- test_keepalive_conn_management failure on Solaris. HOT 3
- Drop support for Python 3.7 HOT 1
- LGTM bot is deprecated HOT 2
- pre-commit fails locally on Python 3.11 macOS HOT 4
- `OSError: [Errno 9] Bad file descriptor` on `socket.shutdown(socket.SHUT_RDWR)`
- Serve will do its job even if stop was called before
- Certain SSL failures can result in worker thread termination
- Potential "cannot join thread before it is started" when shutting down during startup HOT 4
- linkcheck job failing due to utcc.utoronto.ca being down HOT 3
- History is full of uninteresting commits HOT 2
- tox -e pre-commit fails attempting to build cryptography < 3.3 HOT 4
- pre-commit has onerous dependencies HOT 1
- SSL error during _conditional_error will crash worker thread HOT 2
- Failing test with openssl 3.2.0 (test_https_over_http_error) HOT 3
- Host header is not validated HOT 8
- Memory leak when using BuiltinSSLAdapter HOT 3
- [TODO] Research installing signal handlers for the interruption flow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cheroot.