Comments (3)
Thanks a lot! I added it to the SVN, with two slight changes:
- added to OAuthRequestLogger instead
- apache_request_headers() is returned as is, without passing through the
foreach loop.
Unless you have something to add, I'll consider this fixed.
Original comment by brunobg%[email protected]
on 5 Mar 2010 at 10:12
- Changed state: Started
from oauth-php.
Well I wouldn't expect that function in OAuthRequestLogger, because it's not a
logging function, but an utility function used to extract headers from the
webserver.
So in my opinion I shouldn't add it to the Logger class. I added it the
OAuthRequest,
because there are the other utility functions as well, as parse_url and stuff
like
that. So that's where I should expect it.
The apache_request_headers() can be returned as is yes. But please add there a
ksort
as well. So you will get the same sorting order as with $_SERVER and $_ENV.
This will
minimize the differences between the 2 methods.
Besides this, I consider it fixed as well.
Original comment by [email protected]
on 6 Mar 2010 at 9:06
from oauth-php.
I agree that Logger is not the most logical place, but it's the lowest common
dependency and it also uses this function. I added the ksort and closing this.
Thanks
again for the patch.
Original comment by brunobg%[email protected]
on 8 Mar 2010 at 12:46
- Changed state: Fixed
from oauth-php.
Related Issues (20)
- Minor fix that allows for the implementation of your OAuthStore
- OAuth POST request combines parameters from original server request with parameters being sent via oauth for Oauth consumers HOT 1
- Array of Array
- No server associated with consumer_key "..."
- Putting project to packagist
- Saving Recurring events from Google calendar api
- connect Oauth(PHP) Client to Oauth server (ruby on rails)
- cgi sapi oauth callback is required hot fix available
- Error with OAuth instance 2legged
- Invalid consumer HOT 1
- remote server request error
- Error when creating tables with foreign key constraints
- POST data included in signature when content type is "multipart/form-data" HOT 4
- I get error "Authorized token from Service Provider does not match supplied Request Token details"
- Patch for /trunk/example/client/twoleggedtwitter.php
- OAuth Verification Failed HOT 1
- oAuth with PHP 4.4.9
- where is the updateConsumer function? HOT 1
- [deleted issue]
- SQL bug (with fix) in PostgreSQL Store checkServerNonce method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oauth-php.