Giter Site home page Giter Site logo

Comments (5)

skyline0705 avatar skyline0705 commented on August 18, 2024

抱歉刚看到在自动播放上还有使用,综合考虑,isLive的歧义性较多,还是希望对此参数能有一个相对明确的定义,配置一般是作为组件层级的使用,但是目前isLive看起来更接近于业务层级的配置,而不同的业务场景下对isLive的定义其实或多或少都有自己的定义

from chimee.

toxic-johann avatar toxic-johann commented on August 18, 2024

isLive 主要用于标记是否是直播,在 kernel 层处理会有所区别。

另外其他表层插件会根据是否是直播做不同区别的展示。

from chimee.

skyline0705 avatar skyline0705 commented on August 18, 2024

我觉得还是需要明确一下isLive的定义,目前isLive直接跟autoplay设置冲突,设置isLive之后autoplay参数直接默认为true,这块很容易造成使用歧义性

抱歉这块是我设置失误…
不过我还是倾向于isLive更倾向于是对kernel层的设置,而非对表现层插件,表现层的逻辑还是尽量交由开发者来决定比较合适。

from chimee.

toxic-johann avatar toxic-johann commented on August 18, 2024

关于表现层的行为这是因为当时设置皮肤综合考虑了点播和直播的情况。

这一块 @yandeqiang 关注下。

from chimee.

yandeqiang avatar yandeqiang commented on August 18, 2024

目前表现层,如控制条, 拿 isLive 这个参数, 是为了给一个默认图标组合而已,如果,你自己有对图标的组合有做具体的设置,则采用用户的设置。可以看下。https://github.com/Chimeejs/chimee-plugin-controlbar/blob/master/README.md#组件相关问题

from chimee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.