Failed to build on RN 0.17

[chirag04]

Failed to build on RN 0.17

[chirag04]

I'm on vacation till 28th Dec. I will update this on 29th. Happy to accept a PR.

[eyaleizenberg]

This fork has done it already:
https://github.com/taskrabbit/react-native-tooltip

On Wed, Dec 23, 2015 at 6:19 AM Chirag [email protected] wrote:

I'm on vacation till 28th Dec. I will update this on 29th. Happy to accept
a PR.

—
Reply to this email directly or view it on GitHub
#5 (comment)
.

[chirag04]

@jrichardlai seems like you made some interesting changes in your fork. Seems like you tweaked the JS api as well. can you describe the changes here and eventually merge the two codebases if it works out?

[jrichardlai]

@chirag04 I have done some update to the api yes. Thank you for this library it is really useful.
The use case I was trying to do was mosty having a long press on a view and being able to copy it.

I wanted it to be able to create a tooltip on any element, you can put the tooltip around View and Image.

I also wanted to make only one component to use. And it seemed easier in our case to just pass down directly the callback instead of checking the value of the text clicked.

For example you could do this:

class Message extends React.Component {

  handleCopyPress = () => {
    Clipboard.set('Something something');
  }

  handleSendSMSPress = () => {
    alert('Sending SMS');
  }

  render() {
    return (
      <ToolTip
        actions={[
          {text: 'Copy', onPress: this.handleCopyPress},
          {text: 'Send By SMS', onPress: this.handleSendSMSPress},
        ]}
        underlayColor={cssVar('trGreen10')}
        longPress={true}
      >
        <Text>Something something</Text>
      </ToolTip>
    );
  }
}

I removed the ToolTipText component, since it was redundant with the Tooltip but I can keep it and make a PR if you'd like.

[eyaleizenberg]

@jrichardlai For some reason you fork doesn't work for me in RN 0.17
I am hit with: Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object

This is my code:

<ToolTip
  actions={[
    {text: 'x', onPress: () => console.log("X") }
    {text: 'y', onPress: () => console.log("Y") }
  ]}
  underlayColor={'blue'}
  style={textElements.selectedName}
>
  <Text>
    {user.name}
  </Text>
</ToolTip>

it seems that in your ToolTop.ios.js file you need to write in the end: module.exports = ToolTipText

Sorry for posting this here but I couldn't find the 'issues' tab in your fork

[jrichardlai]

@eyaleizenberg thanks let me fix this :)

[jrichardlai]

@eyaleizenberg seems to work fine for me, I added an Example App you can take a look

[jrichardlai]

@eyaleizenberg @chirag04 any news?

@jrichardlai, @chirag04, I think the changes jrichardlai made are great additions to the component. I would suggest merging the changes back into the main project, although I would keep things ES5 compatible like it is today. Any objections?

[chirag04]

No objections. @jrichardlai @sevachb Can one of you PR?

[chirag04]

we merged the two codebases. It should be fixed on master now.