Giter Site home page Giter Site logo

Comments (17)

krober10nd avatar krober10nd commented on May 28, 2024
  • Edge function is indeed smoothed but it appears not to be used inside the generation of the mesh.
    after_smoothed

from oceanmesh2d.

WPringle avatar WPringle commented on May 28, 2024

Interesting, I guess we only tested the result of the smooth edgefx in detail. I'll test your example out.

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Yea the outer box doesn't get the correct initial points especially near the inner nest even despite its sizing function having this variation in it.

from oceanmesh2d.

WPringle avatar WPringle commented on May 28, 2024

It does work if you do enough iterations. There was a bug in dpoly #119 btw that caused it to crash when it did more iterations. At 10 iterations it does the delete close points and starts to work.

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Yea but that’s relying on the mesh adaptation. Shouldn’t the initial point distribution follow the variations in the sizing function?

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

We should create several of these tests.

from oceanmesh2d.

WPringle avatar WPringle commented on May 28, 2024

Yea the outer box doesn't get the correct initial points especially near the inner nest even despite its sizing function having this variation in it.

Hmm yeah I see it should delete some of them initially based on the edgefx. I'll take a look at this too.

from oceanmesh2d.

WPringle avatar WPringle commented on May 28, 2024

Yea the outer box doesn't get the correct initial points especially near the inner nest even despite its sizing function having this variation in it.

Hmm yeah I see it should delete some of them initially based on the edgefx. I'll take a look at this too.

Oh now I get it. Yeah so the h0 of the outer is larger than the edgefx value in the smoothed region so it can't be distributed more finely.

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Yea so then the h0 should be determined after smooth outer is called ay

from oceanmesh2d.

WPringle avatar WPringle commented on May 28, 2024

Yeah if I re-update the h0 for the outer to be equal to the minimum of the ef then I get this:

image

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Yea and what happens if you shrink the inner grade?

from oceanmesh2d.

WPringle avatar WPringle commented on May 28, 2024

That wouldn't affect anything, the grade would go by the outer one

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Shouldn't it go by the minimum grade?

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

In theory we could enforce variable grade only in their respective boxes

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Okay, so I make the initial point formation/rejection use the minimum of all h0

        disp(['    for box #' num2str(box_num)]);
                    % checking if cell or not and applying local values
                    h0_l = min(obj.h0);
                    max_r0 = 1/h0_l^2;   

That wouldn't affect anything, the grade would go by the outer one

And my my observations contradict this.

  • Inner box grade set to 0.15 (outer box grade 0.15)

Innergrade15

  • Inner box grade set to 0.05 (outer box grade 0.15)

Innergrade05

.

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

^ This result is also not because the initial point distribution is correct either. The periodic mesh improvement causes it to smooth out.

from oceanmesh2d.

krober10nd avatar krober10nd commented on May 28, 2024

Nevermind I got it. I'll add it to the dpoly_patch PR

from oceanmesh2d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.