Comments (5)
Hmm, maybe I am missing something here as I tried the following:
I hacked into the choo version in my node_modules
adding the root node argument to the nanohref
call manually, yet choo somehow still tried to handle clicks outside of the host element.
from choo.
choo hasn't really supported being used in like a "sub application" style but it could be really good for that, so I think any feature that will help it excel in that use case would be really welcome :)
The behaviour in your second post kinda looks like a bug in nanohref to me, this is the code that uses the rootNode
value:
https://github.com/choojs/nanohref/blob/80c11c4fdb1c731aad1b94f4c93b0c386b97c69c/index.js#L21-L27
So when you click something, it walks up the tree until it finds either an <a href>
or arrives at the rootNode
. but if you click a link outside the rootNode
, it will still happily find the <a href>
.
from choo.
Assuming the bug in nanohref
is fixed, it should not be too hard to get this into choo itself, but I am really unsure where the option belongs.
A few things that could be done that I'm not a real fan of any yet:
- Add a new key to the options passed to
choo([opts])
. I can't even come up with a name for this. - Allow a DOM Element to be passed instead of
true|false
toopts.href
which scopes nanohref down to children of that element. - Add a second optional argument to
app.mount
that scopes the router to the given selector. I'm not sure if this actually works because ofapp.start
.
I think option 2 would probably be the least invasive, but it's also not really what I'd call an intuitive API. Ugh.
from choo.
Is there any input on this one as well as choojs/nanohref#13 - I'd still love to implement this in one way or the other as it's a hard requirement of what I'm working on right now.
from choo.
You can compose the dependencies quite simply to achieve this. See for example: https://github.com/graforlock/choo-detached
from choo.
Related Issues (20)
- Flicker on route change + window scroll in Safari HOT 2
- Redirects do not work HOT 3
- Page freeze in Safari when navigating using trackpad swipe HOT 3
- Is choo abandoned / no longer maintained? HOT 4
- HTML5 video autoplay in chrome HOT 9
- Running Router On a Specific Path with Hash Routing HOT 3
- Could not query selector id with hypen HOT 4
- Magic in the emitter callback? HOT 4
- v7.0.0 HOT 7
- Is it possible to use choojs with es import syntax? HOT 2
- New feature: Async route support HOT 1
- [domain] ssl-cert expired HOT 6
- Experimenting with custom elements
- Route handler return value HOT 3
- Usage with http-server HOT 1
- What are the precise set of rewrite rules so that if a user specifies app.mount(<PATH>, component) they can retrieve that in the URL?
- Wrong return type for `mount`
- SSL_CTX_use_certificate:ee key too small
- Project abandoned? HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from choo.