Use named logger instead of root

[chrisb2]

Use named logger instead of root

[chrisb2]

Great idea please submit pr. Chris

…

On Sat, 2 Nov 2019, 19:55 John S, ***@***.***> wrote: Would it be possible to update ina219.py to use a named logger rather than the root logger? Being that this library is usually imported, logger.basicConfig() has likely been called by the main module already, so the basicConfig() call in __init__() has no effect (IOW the log level will not be changed at that time if it is different from the main module) Use something like: logger = logging.getLogger(__name__) then change log calls to use logger.info() instead of logging.info() for example. I can fix it and do a PR if you prefer. Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=AAXR2VYRWUOKEVLQEWG5TCTQRUP6TA5CNFSM4JIDM2DKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWJHZOA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXR2V4O2IAYJIMARQ3EW5DQRUP6TANCNFSM4JIDM2DA> .

[JennaSys]

PR submitted.

[chrisb2]

PR merged and new 1.3.0 release created and uploaded to PyPi, see https://pypi.org/project/pi-ina219/1.3.0/

thanks,
Chris

[rrnicolay]

I can't stop the module from printing debug messages. What can I do?
My code:

`import logging
from ina219 import INA219, DeviceRangeError
logging.getLogger('ina219').setLevel(logging.ERROR)

class CurrentReader():
SHUNT_OHMS = 0.1
MAX_EXPECTED_AMPS = 3.0

def init(self):
self.ina = INA219(self.SHUNT_OHMS, self.MAX_EXPECTED_AMPS, busnum=1, log_level=logging.ERROR)`

[chrisb2]

It's not good practice to comment on a closed issue, please open a new one.

Thanks
Chris