Giter Site home page Giter Site logo

Comments (8)

chrisguttandin avatar chrisguttandin commented on May 17, 2024 1

Hi @spencerodai,

thanks for reporting this. I wasn't aware of the problem so far. I made a quick check and it looks like all the apps that I use with angular-prerender don't have this problem. Is your project available somewhere? Or if not could you create a small example which reproduces the problem?

This might of course be totally wrong, but my first guess would be that you somehow prerender the same HTML document twice. Is that possible?

from angular-prerender.

spencerodai avatar spencerodai commented on May 17, 2024 1

thanks for getting back to, no in my app, I am not able to pick up the routes automatically and this is actually desirable in our case. we will be prerending over 20000 pages and its tasking for out ci/cd process so we wanted to have a bit more control and only prerender sections of the app on some deployment event. we also wanted to be able to pass in a route that has edited by our CMS and prerender that page only for example.

As for duplicate state, I think I know the problem and its from my app, not angular-prerender, but I haven't gotten around to fixing this yet.
I will create a feature request for potentially passing in a url to a txt file with prerender routes.

Thanks a bunch

from angular-prerender.

spencerodai avatar spencerodai commented on May 17, 2024

thanks for your reply, I will investigate this further.

I have another question, is there a way to pass a txt file with the defined routes in the command to prerender pages, as opposed to entering a space delimited list?

from angular-prerender.

chrisguttandin avatar chrisguttandin commented on May 17, 2024

Hi @spencerodai, sorry for the delay. You mean a file based replacement for the --include-routes flag? Such an option doesn't exist so far. Feel free to create a separate issue for that if you want it to be added. ;-) Doesn't retrieving the routes automatically work for you use case?

Any use on the duplicate app state problem you're experiencing?

from angular-prerender.

chrisguttandin avatar chrisguttandin commented on May 17, 2024

Hi @spencerodai, I definitely understand that rendering 20000 pages only because one of them changed is not desirable. :-)

I guess that means you ideally also want to turn off the route parsing entirely, right? Right now that can't be done.

from angular-prerender.

mfrancekovic avatar mfrancekovic commented on May 17, 2024

I'm having the same issue with the duplicate app state problem.

What's weird though is that when I run the prerender locally there is only one state script in each file. And when I run the prerender on my CI/CD (GithubActions), it creates a double state script - and the thing breaks because of that.

I can't seem to figure it out. @spencerodai have you had some breakthrough? 🙏

from angular-prerender.

spencerodai avatar spencerodai commented on May 17, 2024

@mfrancekovic I never got around to it as we decided to use angular universal prerenderer instead

from angular-prerender.

chrisguttandin avatar chrisguttandin commented on May 17, 2024

@mfrancekovic Is the project (including the GitHub Actions) publicly available somewhere? Or do you know of another way for me to reproduce the problem?

from angular-prerender.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.