iOS7 + storyboard + Navigation Controller --> show no banner

[morismoris]

iOS7 + storyboard + Navigation Controller --> show no banner

[chrisjp]

I just tried to reproduce this in my own app which uses storyboards and a navigation controller, and it worked fine. How are you setting up the storyboard?

This is the exact code I'm using in my app and it's working fine in both iOS 6 and 7:

UIStoryboard *storyboard;
if (!iPad)
    storyboard = [UIStoryboard storyboardWithName:@"StoryboardiPhone" bundle:nil];
else
    storyboard = [UIStoryboard storyboardWithName:@"StoryboardiPad" bundle:nil];
UINavigationController *navController = (UINavigationController*)[storyboard instantiateInitialViewController];

// init CJPAdController with the nav controller
_adController = [[CJPAdController sharedManager] initWithContentViewController:navController];

// set the ad controller as the root view controller
self.window.rootViewController = _adController;

[morismoris]

Ok,
now it works, but appears over the status bar.

[chrisjp]

Oh yeah I see that happens when the position is set to top. I think this is to do with the way iOS 7 now displays view controllers and status bars. I've tried setting the edgesForExtendedLayout property but it has no effect. Might have to manually move it down by 20px if I can't find a proper solution. I'll look into this more. tomorrow.

[morismoris]

I noticed that in viewDidLayoutSubviews: it may happen that both _iAdView and _adMobView are not null
then both branches if

if (_iAdView) {
....
}

if (_adMobView) {
....
}

are perfomed and AdMob wins! Or if _iAdView != null and _adMobView == null?
I'm not sure you understand all the logic (_showingAdMob and _showingiAd), but it would take something like:

if ((_iAdView != null && _adMobView == null) || (_iAdView != null && _adMobView != null && [kDefaultAds isEqualToString:@"iAd"]))
{
... show iAd
}
else if ((_iAdView == null && _adMobView != null) || (_iAdView != NULL && _adMobView != null && [kDefaultAds isEqualToString:@"AdMob"]))
{
... show AdMob
}
else
{

}

[fbradyirl]

I'm also having the status bar issue when using the 'top' option. My workaround is to place the ads at the bottom although this is not the best place for me.

[chrisjp]

I managed to half fix this problem, but I think (at least in my opinion) it looks awful in this position in iOS 7. It breaks the unified look of the status bar + nav bar pretty badly. In iOS 5 and 6 it was fine, but in iOS 7 it just looks ugly.
I think it would be best if when the ad position is set to "top" the ad is displayed under the nav bar rather than under the status bar. That is currently where I'm planning to go with the code. At the moment I'm having trouble fixing it in either way though. Fixing one part of the problem breaks another...

[chrisjp]

Ignore my previous comment. Turns out that way would be even more complicated. I believe I've managed to fix the issue, but I'll try to test a few more possible use cases before pushing the code.

[chrisjp]

Just pushed an update, it should fix the problems you were having. Can you confirm so I can close this? Or if there's still errors let me know.

@morismoris I just saw your other comment about both ad views not being nil and admob winning. I actually cleaned up that code during this update, I'll have a look now to see if it's still possible that could happen, if I did things right it shouldn't be!

[morismoris]

Ok, great job! Now it works.
Thank you so much!