Doesn't work on linux

[chrismytton]

Doesn't work on linux

[mig-hub]

Ah this is strange because when I made the pull request, there was an automatic test on Travis and it didn't fail.
But maybe you changed the Travis setup recently and added more test cases.

I am personally on a Mac running Lion, but I can access a CentOS.
When I have time I will try to check as well.

Does it have anything to do with the other bug?

[mig-hub]

It might have to do with the way I made it read files until the last line.
There are many ways to do this and some are probably not as portable as others.
Bash is supposed to work the same on all platforms though.

I will try something and if it is no good, I will remove it until we have something solid.

I feel guilty now because making a change on an open source project which doesn't work on linux is quite suicidal :-)

[chrismytton]

No worries! I think this bug was there before your patches got merged in, I only logged them last night so they were out of my brain and in public.

I'm also running a Mac with Mountain Lion, where it works ok. I think it would be worth trying the fix from #6 to see if that makes any difference to this issue.

The reason the travis builds appear to be passing because the script incorrectly exits with 0.

[mig-hub]

OK I'll implement this as soon as possible to see what it does.

[mig-hub]

Hello,

I tried on a linux CentOS (redhat) and it worked fine.
And it was not the code I just changed because I tried to checkout on the commit because and the tests pass as well.

I don't have access to a platform with Ubuntu though.
But at least it means it is not linux-specific.

[mig-hub]

Mate I have the answer I think !!!

trap is bash specific and in your cibuild, you start the whole thing with the sh command.
You have a shebang line, but is only taken into account when made executable and used on its own.
The reason why some systems like MacOS or some linux don't break is because on these systems, sh is bash.

At least I think it is the problem.
I will try and fix this now.

[mig-hub]

Yes the test passes now.
I am a bit puzzled though because we started the test with sh, but the tests definitely start shoreman with the bash command.
I don't see why it would make it work differently.

But once again, the ways of the shell are impenetrable.

[chrismytton]

Hi Mig, sorry I've been a bit quiet, had a busy week! Great work fixing this issue, can't believe it was something so small causing the problem!

Thanks for all the hard work your doing! ✨