Is __MODULE__ preferable?

[styx]

Is __MODULE__ preferable?

[chrismccord]

Can somebody elaborate please? Will using MODULE "just" make my code more stable against renaming? (if so, wouldn't @chrismccord 's aliasing defeat the purpose?)

yes. For me, doing a find/replace in a file should my module name change is a worthy tradeoff. Note: I'm fine with __MODULE__ when I just want to grab a reference to it, but I prefer an alias for structs, since you're often passing those around and accepting them as arguments. To me, the alias reads clearer. I'd rather see:

def name(%User{fname: fname, lname: lname}), do: fname <> " " <> lname

than

def name(%__MODULE__{fname: fname, lname: lname}), do: fname <> " " <> lname

[obrok]

I sometimes do

alias __MODULE__, as: SomeModule 

to guard against renames as well as have a nice looking SomeModule instead of __MODULE__ in the code.

[chrismccord]

My preference here is an alias:

defmodule SomeNamespace.SomeModuleName do
  alias SomeNamespace.SomeModuleName

  defstruct name: nil
  @type t :: %SomeModuleName{name: String.t}

  def name(%SomeModuleName{name: name}), do: name
end

[asaaki]

You can also make the aliasing more concise: alias __MODULE__

[Calamari]

Intetresting reasoning. It totally makes sense. If this rule gets to the Styleguide, can this "why?" be included? I think reading the styleguide is good, but also know why those particular rules are useful, can really help adopting (and remembering) them.

[styx]

Hope @josevalim will left his opinion too (:

[asaaki]

I also adopted this behaviour, so 👍

[defp]

@chrismccord 👍

[schnittchen]

Can somebody elaborate please? Will using MODULE "just" make my code more stable against renaming? (if so, wouldn't @chrismccord 's aliasing defeat the purpose?)

[schnittchen]

Thx @chrismccord, that makes total sense.

[phanimahesh]

I like @obrok's suggestion.

[whatyouhide]

I'm 👍 on @chrismccord suggestion, it's the one I use regularly in my code.

[christopheradams]

Please check PR #114 and let me know if you think it addresses this issue. It advises using __MODULE__ for module self-references, and recommends using an alias if you desire a clearer, unique name.