Empty line after module header?

[christopheradams]

Empty line after module header?

[knewter]

I tend to not have a separator between top-of-module and first-function, but I do have a separator between "alias, use, etc statements" and first-function. So I think my rule of thumb goes something like:

• No newline after defmodule
• No newline before first function def
• Newline after "module-level-code-blocks"

[Kosmas]

@knewter sounds reasonable.

I've just done a PR with your suggestions: #37

[asaaki]

I tend to use the same style like @knewter.

defmodule Foo do
  use SomethingElse
  alias Another.FancyModule

  def my_func do
    # ...
  end

  def another_func(true), do: 1
  def another_func(_any), do: 2

  def bar do
    # ...
  end
end

Basically reduced down to: Add empty lines between (different) functions and function calls/keywords. Don't do put a newline in the beginning or end of a module block and the first/last statement.

I still do not put an empty line between function definitions with identical arity/signature; this is still an open issue at #31.

But this is also just what I adopted from the Ruby community and their style guide.
As both languages look pretty similar it's easy to do so.

[knewter]

Yeah, I think my biggest problem with taking my bullet list into the guide
verbatim is it's not example-y enough yet.

On Fri, Mar 6, 2015 at 10:28 AM, Christoph Grabo [email protected]
wrote:

I tend to use the same style like @knewter https://github.com/knewter.

defmodule Foo do
use SomethingElse
alias Another.FancyModule

def my_func do # ...
end

def another_func(true), do: 1
def another_func(_any), do: 2

def bar do # ...
endend

Basically reduced down to: Add empty lines between (different) functions
and function calls/keywords. Don't do put a newline in the beginning or end
of a module block and the first/last statement.

I still do not put an empty line between function definitions with
identical arity/signature; this is still an open issue at #31
#31.

But this is also just what I adopted from the Ruby community and their
style guide.
As both languages look pretty similar it's easy to do so.

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

Josh Adams
CTO | isotope|eleven http://www.isotope11.com
cell 215-3957
work 476-8671 x201

[asaaki]

I guess this issue can be closed, as the referenced PR #37 is already merged.
cc @niftyn8, @knewter