Comments (2)
If you have a simple toast site like such:
.
├── package.json
├── src
│ └── pages
│ └── index.js
├── toast.js
└── yarn.lock
In the generated public/index.html
, it will drop in <undefined>
in place of the page wrapper.
from toast.
So there's a few issues through this:
- When SSR is being done, there's not any error handling for the pageWrapper trying to be imported in the
incremental
command's script. So then whenrender
is being called, it does ah(undefined, data, h(components, ...))
This should be alright to solve by having a default wrapper as is done in the page-renderer code right now. - page-renderer-pre.js although is lacking some error handling so if any of the dynamic imports fail, it does not rehydrate clientside. The solution of this likely will have to be some tweaks to the logic in page-renderer-pre.
from toast.
Related Issues (8)
- Incremental Compilation HOT 1
- Cannot find module '@sector/toast'
- Exposing API access to Toast's babel config HOT 1
- automatically inject preload tags for page resources HOT 4
- [idea] how could a clear "only do this at build time" API work? HOT 3
- _redirects file not being copied from `static`
- make module-aliases use package.json snowpack alias field HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toast.