Giter Site home page Giter Site logo

Comments (2)

lannonbr avatar lannonbr commented on September 14, 2024

If you have a simple toast site like such:

.
├── package.json
├── src
│   └── pages
│       └── index.js
├── toast.js
└── yarn.lock

In the generated public/index.html, it will drop in <undefined> in place of the page wrapper.

Screenshot 2020-08-22 153350

from toast.

lannonbr avatar lannonbr commented on September 14, 2024

So there's a few issues through this:

  1. When SSR is being done, there's not any error handling for the pageWrapper trying to be imported in the incremental command's script. So then when render is being called, it does a h(undefined, data, h(components, ...)) This should be alright to solve by having a default wrapper as is done in the page-renderer code right now.
  2. page-renderer-pre.js although is lacking some error handling so if any of the dynamic imports fail, it does not rehydrate clientside. The solution of this likely will have to be some tweaks to the logic in page-renderer-pre.

from toast.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.