Giter Site home page Giter Site logo

Comments (2)

kenshaw avatar kenshaw commented on May 14, 2024

I have done quite a bit of testing, actually with Safari, and with Microsoft Edge (through the Edge Diagnostics Adapter). While neither are 100% working right now (Edge has the biggest problems), I am planning on rolling out the necessary modifications/changes to enable them to work "out of the box" in the same way that Chrome is now. Also, at least for the browsers sharing WebKit ancestry, I've made a point to try to write the supplied Actions as backwards compatible. There are some gotchas/problems with how the debugging protocol has changed over time, that do make some APIs not backward compatible, but for the most part those are small-ish in nature and could easily be worked around when needed.

With some modifications to the generated API, however, the code does work now with Safari and Edge -- at least to some degree. The bigger issue for building out compatibility is that Google literally changes the debugging protocol on at least a weekly basis, and I haven't really decided yet what the best way to handle this is, and still be able to offer versions of the generated API that are compatible with older versions of Chrome, or the other browsers. Because I've chosen to make the API type safe, and because the protocol contains "hundreds" of API calls, types, etc. the code base would quickly become unreasonably large (as well as the built binaries!) if we tried to offer out of the box support for every browser.

At this juncture, I'm thinking that "out of the box" compatibility with Chrome's source tree, along with having the higher level Action code support the various, inevitable workarounds for variations between browsers/debugging protocol versions, allowing users to regenerate the API easily (they kind of can already) for other browser versions is the right "path". This would allow those who absolutely need to use a common code base for testing all those browsers to then supply / generate multiple versions of the generated API for all the versions they need to support.

I appreciate the link to Murlok, but I don't really see how it might be able to fix the issues with the generated API.

from chromedp.

joeblew99 avatar joeblew99 commented on May 14, 2024

from chromedp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.