Giter Site home page Giter Site logo

Comments (10)

Gnurou avatar Gnurou commented on August 20, 2024

Looking at the decoded frames with YUView, it is clear that there is some scaling applied by the hardware.

from cros-codecs.

Gnurou avatar Gnurou commented on August 20, 2024

Thinking about it, this is possibly happening through the VAImage rather than decoding itself?

from cros-codecs.

dwlsalmeida avatar dwlsalmeida commented on August 20, 2024

@Gnurou on it

from cros-codecs.

Gnurou avatar Gnurou commented on August 20, 2024

vp80-00-comprehensive-014 also appears to be failing for the same reason.

from cros-codecs.

dwlsalmeida avatar dwlsalmeida commented on August 20, 2024

@Gnurou So when we said that GStreamer/ffmpeg-VAAPI are passing these tests, there's one detail left out.

both GStreamer and ffmpeg ask for NV12 during VAImage creation. They then convert the data into I420 themselves, at a later point.

It may be that decoding to I420 is broken specifically for odd resolutions at the VA-API driver level, I am not sure. For these 175x143 videos, the output seems almost the same, but it has a minor shift, as if some minor scaling took place at some point.

I420 VAImage works fine when the width and height are powers of 2, however.

What do you want to do here? From past experience, diving into intel-media-driver is a massive time sink for little gain..

from cros-codecs.

dwlsalmeida avatar dwlsalmeida commented on August 20, 2024

maybe @ndufresne may have some insight if he's not too busy, I will attach the YUV output.

Unfortunately, there's nothing different at the VA_TRACE level. We are sending the driver the exact same inputs..

from cros-codecs.

dwlsalmeida avatar dwlsalmeida commented on August 20, 2024

output.tar.gz

from cros-codecs.

ndufresne avatar ndufresne commented on August 20, 2024

The wrong output is scale up in a way that isn't just a scaling / postproc artifact, and is blurred too. Its proprietary code, so its hard to tell what going on, as you notice, in GStreamer we force NV12 as anything else straight from the decoder is massively broken and Intel have not care fixing, perhaps its better now, but to me its not really worth it.

In gst we have code to calculat I420 MD5 from NV12 source, I'm sure you could do that same, or simply add a hand written converter.

from cros-codecs.

Gnurou avatar Gnurou commented on August 20, 2024

Thanks - I'll try to render a NV12 frame and convert it to I420 to see if the problem is indeed in the driver. If it is, I guess we should report the bug instead of diving into it ourselves.

from cros-codecs.

dwlsalmeida avatar dwlsalmeida commented on August 20, 2024

This is now passing on Intel thanks to #25

from cros-codecs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.