Giter Site home page Giter Site logo

Comments (9)

squeed avatar squeed commented on June 14, 2024

I wonder if the pathType: ImplementationSpecific is causing issues. What if you change it to Prefix?

from cilium.

squeed avatar squeed commented on June 14, 2024

Aha, I bet https://github.com/cilium/cilium/issues/30071is the same issue

from cilium.

youngnick avatar youngnick commented on June 14, 2024

Yes, after checking, because ImplementationSpecific paths are implemented in Cilium's Envoys as Regex matches, in the absence of special characters to make the regex match any prefix, they behave like an Exact match.

We already have users using ImplementationSpecific as a regex match, so I don't think we can change this now.

For kube-prometheus-stack, it appears as though the pathType is configurable as a Helm value (see https://github.com/prometheus-community/helm-charts/blob/a2a395ad078a330f9afaf3962f7cc47e2cfaf8fc/charts/prometheus/values.yaml#L355), so I'd recommend giving that a go and/or logging an issue with them if the default is still ImplementationSpecific.

from cilium.

adippl avatar adippl commented on June 14, 2024

I've configured pathType: Prefix in helm values and got prometheus working.

I've also tried wildcard in the path path: /.* without setting pathType and this also worked.

Is there any documentation default behavior of pathType: ImplementationSpecific on docs.cilium.io?
It would be nice to warn users about this behavior.

from cilium.

lmb avatar lmb commented on June 14, 2024

@youngnick can we close this as a duplicate?

from cilium.

ti-mo avatar ti-mo commented on June 14, 2024

Let's not close this out yet, I've added requires-doc-change because this seems a little surprising from user POV. Of course it makes sense if you're familiar with regex, but this might be good to call out in the docs.

from cilium.

youngnick avatar youngnick commented on June 14, 2024

Agreed, I think we should make this clearer in the docs.

from cilium.

github-actions avatar github-actions commented on June 14, 2024

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

from cilium.

github-actions avatar github-actions commented on June 14, 2024

This issue has not seen any activity since it was marked stale.
Closing.

from cilium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.