Recent image broke `npm --prefix DIR run` functionality

[circleci-public]

Recent image broke `npm --prefix DIR run` functionality

[JalexChen]

Hi @korya - I'm noticing you are using the lts tag. we just built and pushed up new images with the fixes from yesterday. Could you please check if you are still being affected?

[korya]

Yes, same issue: https://app.circleci.com/pipelines/github/korya/circleci-node-issue/1/workflows/f7721791-349e-4ef2-a14a-65fcf40444ec/jobs/1

[JalexChen]

Hi @korya, from what i've discovered, the good image that you're referencing is an image that i built and was creating a symlink from where nvm was to where node and npm would normally be. since then, that functionality has been changed and the symlink is no longer created, which is causing node to not be found where it normally is; specifically this command in the Dockerfile:

sudo ln -s "$NVM_DIR/versions/node/$(nvm version)/bin/node" "/usr/local/bin/node" && sudo ln -s "$NVM_DIR/versions/node/$(nvm version)/bin/npm" "/usr/local/bin/npm"

there are two solutions here (that i know of):

1. "$NVM_DIR/versions/node/v16.15.0/bin/npm --prefix packages/sub-project test" would allow you to run things correctly, in the package.json test pair, however, this requires you to hard code the node version v16.15.0, which is fine if you are not switching between any versions of node

2. cd packages/sub-project && chmod +x test.sh && npm run test would also run the tests successfully regardless of image and could be implemented as a run step

[korya]

@JalexChen thanks for the update.

The second solution suggested by you is what we used to do in the past before we migrated to workspaces. We will use it until the issue is solved properly.

Do you have any idea what is the priority of this bug and when it is going to be fixed?

[markwhitfeld]

We are also having problems with this image.
I left a comment on the PR: #237 (comment)
Wouldn't rolling back the nvm changes be the step to take in the interim?

[JalexChen]

Hey @korya - a couple of things here:

• --prefix is 1) not compatible with nvm (per the errors) 2) is not aware of workspaces
• instead, using "npm test --workspaces" for your test key in package.json would execute correctly and you could add as many different workspaces within that key; looks like you and your team has migrated to workspaces, so this seems appropriate
• lastly, you could also replace --prefix and run cd packages/sub-project && npm test

let me know if this works for you

[korya]

Thanks for you response.

--workspaces will not work for us because we need to run a script in a specific package at a specific time. Will npm run -w <DIR> <SCRIPT> work with nvm?

The last options works but is less ideal because it requires us to significantly change our build scripts. We would like to avoid doing it because of a regression bug in a CI image.

[JalexChen]

Hi @korya,

yes, npm run -w package/sub-project test would work per the workspaces docs and there are no conflicts with nvm :)

[korya]

@JalexChen Thanks! The suggested approach works as expected.