Comments (5)
ah, i think we should do it even without the -f
. There is no real penalty for removing and recreating the network...that i can think of at least.
from elsy.
FYI lc teardown -f
does remove networks
from elsy.
I think we can probably implement now with https://docs.docker.com/compose/reference/down/
from elsy.
After further review using docker-compose down
outside of lc teardown -f
doesn't work because it breaks https://github.com/cisco/elsy/blob/master/blackbox-test/features/teardown.feature#L35.
I think the best we are going to be able to do is just remove all networks that match the elsy project name, which seems to be (loosely) how docker-compose itself is doing it under the hood, see the following:
- https://github.com/docker/compose/blob/1.12.0/compose/network.py#L88
- https://github.com/docker/docker-py/blob/f127a9ffdc9db1a946c3d7943eaf16b207f33598/docker/api/network.py#L159
- https://github.com/docker/compose/blob/1.12.0/compose/network.py#L97
from elsy.
Closed by #69
from elsy.
Related Issues (20)
- replace calls to docker-compose with compose-go lib
- emberjs-u example has failing unit test HOT 1
- blackbox-test command calls package but does not apply image labels HOT 4
- `lc ci` should call `lc clean` before it starts
- Custom Maven arguments when using `lc ci` HOT 1
- `lc blackbox-test` should destroy all the containers it started, unless `--keep-containers` is specified
- `lc` should abort if `lc.yml` is not present, or if `project_name` is not properly defined HOT 1
- Provide short options for long options HOT 1
- Make Templates Pluggable HOT 1
- Need a Lifecycle Phase for security-scans HOT 1
- Should Label Docker Images with Git Origin Server if Env Var is Available
- lc bootstrap no longer hiding confusing log messages for docker versions > 1.12.6 HOT 2
- Use docker-compose pull --parallel flag
- emberjs-ui Example Tests Fail
- Bootstrap Fails if docker-compose.yml Only Contain Services with Repo's Image
- Docker-compose format version support HOT 3
- lc upgrade HOT 2
- Elsy Templates Incompatible with Docker-Compose File Format 2.1 and Beyond
- Build Breaks with Go 1.11
- Proposal: remove features HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elsy.