Comments (7)
So we can conclude that this is a "feature" for upgrading to the superior pnpm. 😄
from sveltekit-superforms.
Hi, @MattHeslington
This is very strange. I just deployed it, and got the same error 🙁
And as suspected, I switched up
npm
forpnpm
such that I'm deploying apnpm-lock.yaml
instead of apackage-lock.yaml
, and it works perfectly. 😅Check here: https://github.com/shyakadavis/superforms-fail-ts
I don't know the internals, but seems that Superforms has better
pnpm
support than it doesnpm
.Suggestion:
For now, does using
pnpm
violate your workflow? Because for me, the merits of using it outweigh the alternatives around. 🤷♂️Anywho, hoping to here Andreas' input on this. 🙂
Thanks for checking it out, I really appreciate it. pnpm doesn't disrupt my workflow at all, I'll use that instead. Thanks for your help 👍🏻
from sveltekit-superforms.
Haven't deployed on Cloudflare before, I think I need a simple repo that reproduces this problem before I can start figuring things out.
from sveltekit-superforms.
Hi;
When I first this, I was worried, first because of the other issues I saw of validators being added regardless of whether you're using them or not, and also because I use CF for all my deployments; but I wanted to let you know that it worked just fine for me, and it might be an isolated issue.
But, to be fair, I didn't set up a complete Superforms flow - just bare necessities to see if I would run into that issue. And of course, I'm using pnpm
like everyone else, so maybe it might be an npm
issue - who knows 🤷♂️
from sveltekit-superforms.
Hi;
When I first this, I was worried, first because of the other issues I saw of validators being added regardless of whether you're using them or not, and also because I use CF for all my deployments; but I wanted to let you know that it worked just fine for me, and it might be an isolated issue.
But, to be fair, I didn't set up a complete Superforms flow - just bare necessities to see if I would run into that issue. And of course, I'm using
pnpm
like everyone else, so maybe it might be annpm
issue - who knows 🤷♂️
Cheers. I didn't even implement any flow. It's was just a skeleton SvelteKit project with the single, bare-bones welcome page. Just purely having the dependency in package.json caused the deployment to fail. I couldn't work out what was causing the failure, and had to go through everything one-by-one to find the breakpoint.
Thanks for the info, I shall investigate further this afternoon
from sveltekit-superforms.
Haven't deployed on Cloudflare before, I think I need a simple repo that reproduces this problem before I can start figuring things out.
Apologies for the delay. Here are a couple of sample repos, one JS, one TS. They're both just the 'skeleton' option for SvelteKit projects, with Tailwind added. Superforms is not used anywhere - it's just a dependency in each project. Both TS and JS deployments result in the same error log (above) when superforms is a dependency
from sveltekit-superforms.
Hi, @MattHeslington
This is very strange. I just deployed it, and got the same error 🙁
And as suspected, I switched up npm
for pnpm
such that I'm deploying a pnpm-lock.yaml
instead of a package-lock.yaml
, and it works perfectly. 😅
Check here: https://github.com/shyakadavis/superforms-fail-ts
I don't know the internals, but seems that Superforms has better pnpm
support than it does npm
.
Suggestion:
For now, does using pnpm
violate your workflow? Because for me, the merits of using it outweigh the alternatives around. 🤷♂️
Anywho, hoping to here Andreas' input on this. 🙂
from sveltekit-superforms.
Related Issues (20)
- Vine & other deps getting unnecessarily installed HOT 1
- Validation doesn't work with different pages HOT 1
- New Adapter: @effect/schema HOT 3
- OpenAPI/Pydantic Validation Support HOT 3
- How to set an error during onSubmit() HOT 1
- Clearing previously stored errors on client HOT 8
- Two forms in same page. When a submit the form 2, data returned in form 1 is cleared. HOT 1
- [Question]What is the good practice of returning `fail` caused by things other than form validation errors? HOT 2
- Provide reducers/reviviers for devalue in superForm/superValidate functions HOT 1
- After submit the validation data is empty HOT 5
- Proxy object in nested array HOT 6
- Superforms is not compatible with Svelte 5 (preview) in rune mode HOT 2
- Error with use:enhance when using on Safari IOS 13.6 HOT 3
- simple-runtype HOT 1
- accept union type in generic component HOT 6
- Issue with nested data custom validation. An error is thrown when the path is not explicitly passed. HOT 4
- Support new Valibot piping? HOT 16
- SuperDebug CSS is included in SSR-only production build HOT 5
- how to implement progress bar for file uploading
- numberProxy, stringProxy don't restore with snapshot restore
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sveltekit-superforms.