BUG: API - replying to deleted (hidden) argument throws 500 Internal Server Error

[citizenos]

BUG: API - replying to deleted (hidden) argument throws 500 Internal Server Error

[tiblu]

@loorm @ilmartyrk What should happen from User experience perspective if a User replies to a deleted (hidden) argument? Think from FE perspective and we'll do the API behavior based on that.

Questions in my head:

• FE: Should the "Reply" button even exist in the UI?
• API: What would API do, if someone calls the deletion from API and the argument has been already deleted?

[tiblu]

@loorm @ilmartyrk What should happen from User experience perspective if a User replies to a deleted (hidden) argument? Think from FE perspective and we'll do the API behavior based on that.

Questions in my head:

• FE: Should the "Reply" button even exist in the UI?
• API: What would API do, if someone calls the deletion from API and the argument has been already deleted?

Implementation details in the first comment.

[ilmartyrk]

@tiblu is 404 sensible or would 403 make more sense? I'll have to add that current 500 error was thrown while adding activity as parent object was empty thus not having the toJSON() method, actual reply was posted and is visible after page reload.

[tiblu]

In my head 404 makes more sense, as it is "deleted" thus "does not exist".

[ilmartyrk]

Fixed by citizenos/citizenos-fe@c440a32 and 902d2b9