Comments (11)
Triage 23. We will go through the report and create separate Github issues, where we are able to replicate errors. Then these issues will be linked here and will be separately prioritized and solved.
from ep_image_upload.
Legally reviewed, no additions.
from ep_image_upload.
I distilled this down to the issues left to resolve as a good majority are now done:
So TLDR is #8 needs dealing with and this might take a core change which wont be available till 1.8.9 ~March 2021.
from ep_image_upload.
Details
OS: Win 8.1
Browser: Chrome Version 81.0.4044.113
Testpad: https://board.net/ (I suppose they have ep_copy_paste_images as well as ep_image_upload installed)
Drag and Drop inside Pad
- Drag and Drop onto a blank line
Doesn't work
- Drag and drop onto content with a line
works when cursor is left to the text but not when in be
Copy to clipboard/ Paste (using control c / v) inside Pad
- Paste onto a blank line
doesn't work
- Paste onto a line populated with content
doesn't work
- right click copy/paste
doesn't work
Cut to clipboard/ Paste (using control x / v)
- Paste onto a blank line
doesn't work
- Paste onto a line populated with content
doesn't work
- right click cut/paste
doesn't work
Image appearance
- Image is never distorted
correct
- Image has correct color balance
correct
Alignment
- Image can be aligned using ep_align
no statement possible
Resize
- Can resize the image
yes, using tab (resize smaller) or shift+tab (resize larger until original size is reached) when the cursor is left of the image
Browser Resize
- Can still nagivate the page
yes
- Images can be moved / selected / resized
- select
Image can never be selected by tipping it, but it can be selected by dragging the cursor over several lines. But then ctrl+c/ctrl+x works to move it for example to libre office (so it's in the clipboard), but when it's copied to another place in the pad it disappears)
- resize
works with tab/shift+tab like described above
- select
Keyboard
- Caret can be moved between images
yes, but when we have 2 images and the caret is in beetween these two, delete doesn't delete the respective line but rather the image below
- Backspace deletes an image when caret is placed after the image
not possible, because caret/cursor always jumps to the left
- Delete removes an image when caret is placed before the image
yes
- Backspace deletes an image when caret is placed before the image
yes
Further observations
- when I delete an image, it can be restored with ctrl+z (but not when cut with ctrl+x)
- being in line below and Backspace doesn't delete the image but rather jumps to the left of the image
- when image is in the last line, it isn't possible to create an new line below. Enter moves the image below to the new line. Moving the cursor to right of the image isn't possbile as it moves directly back left
- when several images are inside the pad, ctrl+z destorys several and then they can't be restored
from ep_image_upload.
Thanks for the very detailed report! We'll have a look at this and prioritize.
We have 1.5 developers in the organization so it may not get a very high priority.
We welcome all pull reqests!
from ep_image_upload.
@tiblu @ilmartyrk Any update on this re the new EP version?
from ep_image_upload.
@loorm the cursor positioning issue was closed due to unable to fix it in the EP core. Drag and drop needs some investigation
from ep_image_upload.
Got it! Assigning for Triage, so you can timebox the investigation.
from ep_image_upload.
Triage 47. Needs code review and testing. Esti. investigation time 4h. Sending to investigation.
from ep_image_upload.
@anettlinno had a look, Seems that drag and drop works in firefox. But in Chrome and Opera it opens image in new tab. When trying to drag and drop image from new tab it adds the url of the image as in my local pc starting with C://... thus not starting upload. I guess that to make this feature work there needs to be extra functionality added for it to work in Chrome and Opera too, Also regarding the resize using tab and shift+tab. This acutally adds or removes indentation. But it doesn't have permanent effect in exported document. It also depends on browser window/screen size. So it kind of visually works for a single user, but for it to really have similar effect on all other users too, it should have changes written into code
from ep_image_upload.
@ilmartyrk thanks for the update! As it is not urgent thing for users then I would propose to park this issue until we decide if we are going to continue with EP editor or change it to any other.
Iยดm sending it back to In prep.
from ep_image_upload.
Related Issues (20)
- Invalid URL TypeError HOT 8
- Line numbering is broken -- Testing in Azure HOT 6
- Failed to load modules HOT 2
- images uploaded with ep_copy_paste_images are not displayed HOT 2
- BUG: Support to configure upload image button (addImage) in toolbar has been lost
- local storage in docker HOT 1
- Deleting locally stored images
- Images do not get exported to pdf or word
- Can't install the plugin on etherpad-lite-win-1.8.14 HOT 1
- ctrl v of an image should create a new file if filesystem is being used HOT 5
- BUG: Error messages not looking like errors.
- upgrade from ep_copy_paste_images fails
- migrating from ep_copy_images
- How to use Private S3 Bucket/File System
- [FR] auto create pad folder on pad creation ?
- Compatibility with ep_align
- Add Drag and Drop feature
- TypeError: clientVars.ep_image_upload is undefined HOT 2
- Error: Cannot find module 'graceful-fs' HOT 2
- TypeError: Uncaught TypeError: Cannot read properties of undefined (reading 'mimeTypes')
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ep_image_upload.