Giter Site home page Giter Site logo

Comments (5)

Athelena avatar Athelena commented on June 28, 2024 2

I just had a quick play and I noticed that if you remove from the building attributes "osm_tags" then the buildings can be visualised in QGIS. Can't tell you why though πŸ˜… @liberostelios will know better for sure. I'm guessing it's something to do with parsing the nested hierarchy.

from cityjson-qgis-plugin.

Athelena avatar Athelena commented on June 28, 2024 2

Haha, no worries! Happy to help πŸ˜„

So what you store in your file is not wrong, you're allowed to have nested attributes according to the schema, I validated it to make sure. @liberostelios said he will fix this issue soon since the plugin should be able to handle nested attributes. I also listed it as an issue for ninja (#57) since reading them as just a string is perhaps not super useful either.

For now I suggest perhaps un-nesting the attributes and maybe you can instead group them as such: "osm_tags_addr:city", "osm_tags_addr:postcode", etc. This will help if you wish to use them as attributes within QGIS.

I just took a small subset of 5 buildings with cjio and played with attributes manually to check if nesting was the issue. But I think you can easily just change this in your script?

from cityjson-qgis-plugin.

AdrianKriger avatar AdrianKriger commented on June 28, 2024 2

@Athelena. Lets leave the result as is - I like the nested attributes. It's intuitive.
What I will do is add a function that transforms the CItyModel to a "flatter" data-structure; should the user choose.

You have been extremely helpful. Thank you.

from cityjson-qgis-plugin.

AdrianKriger avatar AdrianKriger commented on June 28, 2024 1

One thumbs up @Athelena - for the super service and a πŸ˜„ for the grammar.

Do you suggest non-nested attributes? Should I write the CityJSON differently?
How did you remove the attributes?

from cityjson-qgis-plugin.

Athelena avatar Athelena commented on June 28, 2024 1

No problem! Always happy to help and it's nice to see people developing open data and open code πŸ˜ƒ

from cityjson-qgis-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.