Giter Site home page Giter Site logo

Comments (7)

elisekalstad avatar elisekalstad commented on August 28, 2024

This is also an issue as a Program Admin downloading the CSV for applications.

from civiform.

swatkat1 avatar swatkat1 commented on August 28, 2024

@elisekalstad - If it's a CSV issue, can we get a sign off from other entities too?

from civiform.

nb1701 avatar nb1701 commented on August 28, 2024

Sorry @swatkat1 , didn't notice you had picked this up before I put up a PR. I pinged Isabel and Shreya to make sure this is okay to do for other CEs as well. It will affect CSV, API, and PDF exports, as well as the UI where we show timestamps.

from civiform.

avaleske avatar avaleske commented on August 28, 2024

Confirmed with Matthew at Arkansas that since they're not fully live yet we can switch to an ISO date format without needing to put it behind a feature flag first. Once we know what release it's in we can let them know.

I think the best format to use is the ISO_OFFSET_DATE_TIME from https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html, which looks like 2011-12-03T10:15:30+01:00 but we should confirm that excel and tableau do the right thing and parse it correctly and let you pick the display format that you want.

from civiform.

nb1701 avatar nb1701 commented on August 28, 2024

@elisekalstad We were thinking for CSV and the API, we could use ISO_OFFSET_DATE_TIME which looks like 2011-12-03T10:15:30+01:00 as mentioned above, but that perhaps is not the most readable thing. For PDF we could maybe do RFC_1123_DATE_TIME which looks like Tue, 3 Jun 2008 11:05:30 GMT. Or we could just always do ISO. What do you think?

Edit: Actually, it seems Excel may not recognize this as a date. Had a discussion in our sync, still not really settled on what we're going to do. We'll jam with @isabelcshaw and figure out what we want to do here. I think probably for the API we should use the ISO format, but CSV/PDF could be whatever.

from civiform.

swatkat1 avatar swatkat1 commented on August 28, 2024

@nb1701 and @avaleske --> Elise is OOO till mid march. I am adding @msprenke for visibility.

from civiform.

nb1701 avatar nb1701 commented on August 28, 2024

For now, we will move the API output to ISO 8601, and will leave the CSV export as-is expect with a two-digit hour always.

from civiform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.