Comments (3)
- I support your proposal. The APP argument makes no sense currently.
- It was already possible to store the format string into progmem. The compiler is able to remove the unused APP argument. My definition is
extern void LDL_DBGINF(const char *__fmt, ...);
#define LDL_DEBUG(APP,FMT, ...) LDL_DBGINF(PSTR(FMT), ##__VA_ARGS__);
- I don't like the last refactoring, that inserts the _FUNCTION_ argument. It adds more program code, requires more flash memory and I don't see any advantage in debug output. I did not merge these changes into my local branch.
from lora_device_lib.
Oh yes, you're right. I've confused myself 😄
I've gone ahead and removed the app argument and function macros.
from lora_device_lib.
Completed in 0.4.5.
from lora_device_lib.
Related Issues (20)
- OTAA not recieving JoinAccept HOT 2
- Radio interrupt not raised when message received in SF11 and SF12 HOT 3
- Proposal to remove diagnostic events from ldl_mac_response_type HOT 2
- Maximum sleep time due to LDL_MAC_ticksUntilNextEvent() values HOT 7
- Simplify function timerDelta()
- Discussion: Better control of confirmed uplink messages from application HOT 4
- possible deprecated #define LDL_LITTLE_ENDIAN HOT 1
- preferred way to use DeviceTimeSync HOT 4
- Add a check for maximum message size on send HOT 2
- Increment devNonce on every join request HOT 6
- Not receiving Join Accept HOT 2
- LPTIM 16 bit ticker HOT 1
- ticksUntilNextEvent keeps returning UINT32_MAX HOT 2
- Lora modules driver
- I am having trouble importing this library to arduino?
- OTAA join HOT 5
- OTAA join-accept not being received HOT 2
- Incorrect MIC generated LoRaWAN 1.1 retransmissions and command responses HOT 1
- Join timeout HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lora_device_lib.