Code completion doesn't respect allCommitCharacters

[clangd]

Code completion doesn't respect allCommitCharacters

[fannheyward]

Correct me if I'm wrong. coc already added commitCharactersSupport, but not fallback to use allCommitCharacters?

[kadircet]

right, as @sam-mccall pointed out in an offline discussion the logic in https://github.com/neoclide/coc.nvim/blob/master/src/languages.ts#L651 doesn't take allCommitCharacters into account when there's none send with the completionitem.

[fannheyward]

I'll check coc side. But first I needed to download clangd HEAD build, do you known anywhere provides a nightly build download?

[sam-mccall]

No worries, I think I just about have a patch for this. The style might be wrong but I have to learn sometime :-)

For future: https://github.com/clangd/clangd/releases has weekly snapshots (well, one so far, just got it working).
But the build is from a couple of days ago, and the allCommitCharacters patch landed literally today in LLVM.

[sam-mccall]

https://github.com/neoclide/coc.nvim/pull/1565/files

[fannheyward]

Merged.