diagnostics floats are really noisy

[clangd]

diagnostics floats are really noisy

[fannheyward]

The diagnostic format is defined [source code] [severity] message in https://github.com/neoclide/coc.nvim/blob/3c462c6486725f7e3a82900e75c671d5d31bf093/src/diagnostic/manager.ts#L306. coc needs to add diagnostic format support.

[kadircet]

btw, we might also consider moving the full diagnostic info to the command line and only show diagnostic message in the floating window.

I also think it would be better if diag(floating window) hasn't moved with the cursor, it could pop-up once the user enters diag range and stay there until user exits it.

[sam-mccall]

I also think it would be better if diag(floating window) hasn't moved with the cursor, it could pop-up once the user enters diag range and stay there until user exits it.

Yeah, I don't know if this is easy/hard to do.
I do find myself wishing it was pinned to column zero instead of anchored at the cursor, because it tends to truncate or wrap.

[fannheyward]

I also think it would be better if diag(floating window) hasn't moved with the cursor

If you are using Neovim, add "diagnostic.virtualText": true to coc-settings.json, the diagnostic message will pinned with virtual text at the end of line.

[sam-mccall]

Thanks for the pointer. I think that's the one for preview window, and this one is for floating windows:
https://github.com/neoclide/coc.nvim/blob/3c462c6486725f7e3a82900e75c671d5d31bf093/src/diagnostic/manager.ts#L458

(Some of the concerns apply to both, but space is much less of a concern in the preview window for instance)

If you are using Neovim, add "diagnostic.virtualText": true to coc-settings.json, the diagnostic message will pinned with virtual text at the end of line.

This is nice - I tried it out, but one of our goals is to support a bunch of internal users who are using a particular version of vim (fairly recent: 8.1.2269).

[sam-mccall]

So while customizability (and highlighting) is nice, playing with this makes me more convinced that the defaults can be improved first. Does this seem more readable

Before:

After:

[sam-mccall]

@kadircet points out that floating windows use a different color per severity, as well as the gutter marker, and the Error: is mostly noise:

[sam-mccall]

neoclide/coc.nvim#1564

[fannheyward]

Changed on coc by adding diagnostic.format, without change the default style. User can define format they want, eg drop the source part.

[sam-mccall]

Thanks for doing that!
Having it customizable means ~all power-users will be happy, but IME most non-power-users won't work out how to change it even if it bothers them.

How do you feel about changing the default style? I think either "%message\n[%source%code]" or "%message" would be a clearer default, with more info available to those who want it.

[fannheyward]

I don't like to change default style. Current style [source code] [E] message in most case is ok, for example:

1. [pylint E0104] [E] Return outside function
2. [json 515] [E] Colon expected
3. [tsserver 6133] [I] 'a' is declared but its value is never read.

The code part is needed and useful for users. On clangd side, the noisy is because too-long-error-code. We can overwrite the default diagnostic.format in coc-clangd, I make it default %message [%source].

[chemzqm]

@fannheyward overwrite default configuration by extension doesn't seem to be a good idea, the user install an extension and the behavior unexpected changed.

[fannheyward]

@chemzqm the overwrite configurations has been removed.