Feature request : add "external" shaka plugin version in compilation

[clappr]

Feature request : add "external" shaka plugin version in compilation

[leandromoreira]

😄 don't worry enjoy your Bastille Day there.

[tchakabam]

@kslimani Hey thanks for the notice! I'll get back to you with the test results on monday, but code-wise it looks all great! :)

[leandromoreira]

I really liked your current proposition. 👍 Thank you @kslimani

[kslimani]

@leandromoreira i see also that in current master, a compilation "behaviour" has been broken since 2.0.7 release tag :

Previously, npm run build was compiling unminified es5 "dist" version and npm run release was compiling the minified es5 "dist" version. Do you want me to restore this in my (incoming soon) PR ?
(i ask because the bump shell script is expecting this behaviour).

I propose also to add an npm run dist shortcut which will run the build and release npm tasks.

[leandromoreira]

Do you want me to restore this in my (incoming soon) PR ?

No, I think this is better.

[kslimani]

@leandromoreira then you should revert, because in my PR i restore the previous behaviour

EDIT: just describe which npm run tasks you wants and i will update the PR.

[leandromoreira]

I loved the npm run dist that does all. Is it now releasing a minified es6?

[kslimani]

In the current merged PR :

• npm run build create the unminified es5 plugin bundle file
• npm run release create the two minified es5 plugin bundle files (with and without shaka as external lib)
• npm run dist ==> npm run lint && npm run build && npm run release

EDIT :
There is (far i known) no minified es6.
The bundle compilaton tasks are also creating the source maps files for each bundle (as @tchakabam introduced).

[kslimani]

So, if you run npm run dist, it will run lint task and then generate the following files :

// The es5 plugin unminified with shaka-player bundled (and source map) ~ 180k
dash-shaka-playback.js
dash-shaka-playback.js.map

// The es5 plugin minified with shaka-player bundled (and source map) ~ 171k
dash-shaka-playback.min.js
dash-shaka-playback.min.js.map

// The es5 plugin minified without shaka-player bundled (and source map) ~ 7k
dash-shaka-playback-external.min.js
dash-shaka-playback-external.min.js.map

[leandromoreira]

I think this solution you did is perfect!

[kslimani]

Ok, then, no revert is required 👍

@leandromoreira please note, that you will need to run yourself (or another core member) the dist task and commit to master in order to create the new bundle files.

[kslimani]

@tchakabam could you please get current master and verify if it satisfy your needs ?

[leandromoreira]

Ohh yeah, I'm planning to do a new release, @kslimani did you tried with newer clappr? can I npm publish it too?

If the answer is yes for all questions above I'll be happy to release a new version, are you girls/guys @tchakabam @vagnervjs @towerz okay with that?

[vagnervjs]

That's fine by me, great work again @kslimani!

[kslimani]

I have not made intensive tests, i just checked that webpack-dev-server demo page run with npm start was working. I was relaying on @tchakabam to performs additional tests. (especially the "shaka less" bundle)

BTW @leandromoreira i am also planning to add new Clappr closed caption capability support to this plugin. (but no eta, maybe next week, it is Bastille Day tomorrow in France). I will build a custom Clappr player from master to tests as it is not released yet.

[tchakabam]

@kslimani hey but what is now with an external bundle that is not minified?

seems we dont have that anymore now :(

[tchakabam]

i ll make a PR for that ;) otherwise looks fine to me.

[tchakabam]

#33

[leandromoreira]

It's done! 💃 thanks a lot, @kslimani and @tchakabam