Comments (11)
Hi, @Kushagra8888 thanks for the blazing fast reply.
I completely agree, but I would like to add a few things
- I can understand that being a small team it's difficult to prioritise the overhead work required for this but working incrementally could be fruitful in future.
What's your opinion about implementing container components like (Grid, Card...etc)
Curious as to how you came across knit-ui
So I came across @clarisights a couple of months ago & I am a huge fan of design systems, UI & React so KnitUI
attracted me & here I am 😉
from knitui.
Yes, you're right about Drawer and Slider being completely distinct components. Thanks for your suggestions! I'll forward them to the design team...
from knitui.
Hi @pranshuchittora , Thanks for checking out knit-ui and providing your feedback!
We used rc components in some cases for the following reasons:
- it simplified the set of features that we would need to build and maintain. Being limited on resources and time the more code we add, the more surface area we introduce for bugs and inefficiencies.
- benefiting from the updates and bug fixes that go into rc components from the community.
- the core functions that we require according to our design systems, could be implemented using rc components without over-customisation.
Would love to know your thoughts on this matter...
P.S: Curious as to how you came across knit-ui
from knitui.
Certainly, if see significant value add for the time that needs to be invested, we would plan to refactor them.
We may implement some container components as well, but I'm unsure about it and would defer it to our UX.
@arorayash Would it be possible to add a list of components that we are planning to implement into knit-ui, maybe in the Readme?
from knitui.
@pranshuchittora Here's the list of things planned to be implemented: https://www.figma.com/file/o3UDrumhtDT0huZEsPnGPw/KnitUI-planning?node-id=0%3A1
from knitui.
Thanks, @Kushagra8888 sounds interesting.
In the doc, it's Drawer/Slider
??
The Drawer
is nav related & slider is for input 😕
And, there are few comps I would like to add.
- AppBar/NavBar
- Slider (Input)
- Progress Bars (Circular & Linear)
- Chips (Useful if filters applied on matrices)
from knitui.
Is it possible to get some design mockups?
from knitui.
@pranshuchittora Unfortunately we don't have them now, and it might take some time document the requirements, but I'll share them with you when they are avilable...
from knitui.
No problem, I will start with Grid and other containers.
from knitui.
I think this hasn't been published on NPM
.
Any idea abt this -> https://www.npmjs.com/package/knit.design (Might be an old one, better unpublish this 😕 )
from knitui.
Hey the actual library is here - https://www.npmjs.com/package/knit-ui
Will unpublish the old one. Thanks for notifying. 👍
from knitui.
Related Issues (20)
- Explore usage of notistack for alerts HOT 1
- disabled button should not change color on hover/active/focus HOT 1
- Button does not respect the onHover prop.
- For input with disabled prop, the cursor should "not-allowed"
- Modal: Do not display the footer if there is no content.
- [lint]: tslint-config-prettier conflicting with tslint rules
- Implement Breadcrumb component
- Add readme.md
- Add ErrorBoundary
- Add code coverage tools
- Add type definitions for KnitUI components
- Implement onLeave animations for Modal HOT 1
- Add additional prop to button to change icon color on hover HOT 7
- Add additional prop for custom fill in icons for selected color indication to be dynamic
- Icon's size does not change with Button size HOT 1
- Support onFocus & onBlur in Input props HOT 2
- Integrate npm package publishing through github
- The cursor on the buttons should default to pointer HOT 1
- Clubhouse integration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knitui.